[ovs-dev] [PATCH v3 01/13] ofproto: Don't use connmgr after destruction.

2016-09-12 Thread Jarno Rajahalme
Set ofproto's connmgr pointer to NULL after the connmgr has been destructed, and check for NULL when sending a flow removed notification. Verified by sending the flow removed message unconditionally and observing numerous core dumps in the test suite. Found by inspection. Fixes: f695ebfae5 ("ofp

Re: [ovs-dev] [PATCH v3 01/13] ofproto: Don't use connmgr after destruction.

2016-09-13 Thread Ben Pfaff
On Mon, Sep 12, 2016 at 01:52:31PM -0700, Jarno Rajahalme wrote: > Set ofproto's connmgr pointer to NULL after the connmgr has been > destructed, and check for NULL when sending a flow removed > notification. > > Verified by sending the flow removed message unconditionally and > observing numerous

Re: [ovs-dev] [PATCH v3 01/13] ofproto: Don't use connmgr after destruction.

2016-09-13 Thread Jarno Rajahalme
> On Sep 13, 2016, at 10:56 AM, Ben Pfaff wrote: > > On Mon, Sep 12, 2016 at 01:52:31PM -0700, Jarno Rajahalme wrote: >> Set ofproto's connmgr pointer to NULL after the connmgr has been >> destructed, and check for NULL when sending a flow removed >> notification. >> >> Verified by sending the

Re: [ovs-dev] [PATCH v3 01/13] ofproto: Don't use connmgr after destruction.

2016-09-13 Thread Ben Pfaff
On Tue, Sep 13, 2016 at 02:45:54PM -0700, Jarno Rajahalme wrote: > > > On Sep 13, 2016, at 10:56 AM, Ben Pfaff wrote: > > > > On Mon, Sep 12, 2016 at 01:52:31PM -0700, Jarno Rajahalme wrote: > >> Set ofproto's connmgr pointer to NULL after the connmgr has been > >> destructed, and check for NULL

Re: [ovs-dev] [PATCH v3 01/13] ofproto: Don't use connmgr after destruction.

2016-09-15 Thread Jarno Rajahalme
> On Sep 13, 2016, at 5:13 PM, Ben Pfaff wrote: > > On Tue, Sep 13, 2016 at 02:45:54PM -0700, Jarno Rajahalme wrote: >> >>> On Sep 13, 2016, at 10:56 AM, Ben Pfaff wrote: >>> >>> On Mon, Sep 12, 2016 at 01:52:31PM -0700, Jarno Rajahalme wrote: Set ofproto's connmgr pointer to NULL after