Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-25 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: > Flow key handleing changes: > - Add VLAN header array in struct flow, to record multiple 802.1q VLAN > headers. > - Add dpif multi-VLAN capability probing. If datapath supports multi-VLAN, > increase the maximum depth of nested OVS_K

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-26 Thread Xiao Liang
On Tue, Jul 26, 2016 at 12:52 AM, Ben Pfaff wrote: > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: >> Flow key handleing changes: >> - Add VLAN header array in struct flow, to record multiple 802.1q VLAN >> headers. >> - Add dpif multi-VLAN capability probing. If datapath supports

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-26 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 11:51:25AM +0800, Xiao Liang wrote: > On Tue, Jul 26, 2016 at 12:52 AM, Ben Pfaff wrote: > > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: > >> Flow key handleing changes: > >> - Add VLAN header array in struct flow, to record multiple 802.1q VLAN > >> heade

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-27 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: > Flow key handleing changes: > - Add VLAN header array in struct flow, to record multiple 802.1q VLAN > headers. > - Add dpif multi-VLAN capability probing. If datapath supports multi-VLAN, > increase the maximum depth of nested OVS_K

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-30 Thread Xiao Liang
Thanks! I'm working on code changes according to your comments. I think we need more discussion about the ethertype matching. Please see inline. Thanks, Xiao On Thu, Jul 28, 2016 at 2:40 AM, Ben Pfaff wrote: > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: >> Flow key handleing chan

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-03 Thread Eric Garver
On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xiao Liang wrote: > Thanks! I'm working on code changes according to your comments. I > think we need more discussion about the ethertype matching. Please see > inline. Can we reach an agreement on the ethertype matching? It has implications on the kernel

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-03 Thread Ben Pfaff
Thanks for the replies, I have some further responses below. On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xiao Liang wrote: > On Thu, Jul 28, 2016 at 2:40 AM, Ben Pfaff wrote: > > I'm concerned about backward compatibility. Consider some application > > built on Open vSwitch using OpenFlow. Today,

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-03 Thread Ben Pfaff
On Wed, Aug 03, 2016 at 10:25:21AM -0400, Eric Garver wrote: > On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xiao Liang wrote: > > On Thu, Jul 28, 2016 at 2:40 AM, Ben Pfaff wrote: > > > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: > .. snip .. > > > I'm concerned about backward compati

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-06 Thread Xiao Liang
On Thu, Aug 4, 2016 at 6:07 AM, Ben Pfaff wrote: > Thanks for the replies, I have some further responses below. > > On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xiao Liang wrote: >> On Thu, Jul 28, 2016 at 2:40 AM, Ben Pfaff wrote: >> > I'm concerned about backward compatibility. Consider some appl

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-06 Thread Ben Pfaff
On Sun, Aug 07, 2016 at 10:54:00AM +0800, Xiao Liang wrote: > On Thu, Aug 4, 2016 at 6:07 AM, Ben Pfaff wrote: > > Thanks for the replies, I have some further responses below. > > > > On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xiao Liang wrote: > >> On Thu, Jul 28, 2016 at 2:40 AM, Ben Pfaff wrote

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-19 Thread Eric Garver
On Sat, Aug 06, 2016 at 08:04:44PM -0700, Ben Pfaff wrote: > On Sun, Aug 07, 2016 at 10:54:00AM +0800, Xiao Liang wrote: > > On Thu, Aug 4, 2016 at 6:07 AM, Ben Pfaff wrote: > > > Thanks for the replies, I have some further responses below. > > > > > > On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xia

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-19 Thread Ben Pfaff
On Fri, Aug 19, 2016 at 04:19:31PM -0400, Eric Garver wrote: > On Sat, Aug 06, 2016 at 08:04:44PM -0700, Ben Pfaff wrote: > > On Sun, Aug 07, 2016 at 10:54:00AM +0800, Xiao Liang wrote: > > > On Thu, Aug 4, 2016 at 6:07 AM, Ben Pfaff wrote: > > > > Thanks for the replies, I have some further respo

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-19 Thread Eric Garver
On Fri, Aug 19, 2016 at 01:24:10PM -0700, Ben Pfaff wrote: > On Fri, Aug 19, 2016 at 04:19:31PM -0400, Eric Garver wrote: > > On Sat, Aug 06, 2016 at 08:04:44PM -0700, Ben Pfaff wrote: > > > On Sun, Aug 07, 2016 at 10:54:00AM +0800, Xiao Liang wrote: > > > > On Thu, Aug 4, 2016 at 6:07 AM, Ben Pfaf

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-19 Thread Ben Pfaff
On Fri, Aug 19, 2016 at 04:42:18PM -0400, Eric Garver wrote: > On Fri, Aug 19, 2016 at 01:24:10PM -0700, Ben Pfaff wrote: > > On Fri, Aug 19, 2016 at 04:19:31PM -0400, Eric Garver wrote: > > > On Sat, Aug 06, 2016 at 08:04:44PM -0700, Ben Pfaff wrote: > > > > On Sun, Aug 07, 2016 at 10:54:00AM +080

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-19 Thread Mooney, Sean K
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Friday, August 19, 2016 9:57 PM > To: Xiao Liang ; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling) > > On Fri,

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-20 Thread Eric Garver
On Sat, Aug 20, 2016 at 01:41:26AM +, Mooney, Sean K wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > > Sent: Friday, August 19, 2016 9:57 PM > > To: Xiao Liang ; dev@openvswitch.org > >

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-09-08 Thread Xiao Liang
On Sat, Aug 20, 2016 at 9:41 AM, Mooney, Sean K wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff >> Sent: Friday, August 19, 2016 9:57 PM >> To: Xiao Liang ; dev@openvswitch.org >> Subject: Re:

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-09-09 Thread Mooney, Sean K
> -Original Message- > From: Xiao Liang [mailto:shaw.l...@gmail.com] > Sent: Friday, September 9, 2016 5:27 AM > To: Mooney, Sean K > Cc: Ben Pfaff ; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ > tunneling) > > O

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-09-09 Thread Xiao Liang
switch.org] On Behalf Of Ben >> Pfaff >> >> Sent: Friday, August 19, 2016 9:57 PM >> >> To: Xiao Liang ; dev@openvswitch.org >> >> Subject: Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ >> >> tunneling) >> >> >> >> On Fr