Re: [ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-10-13 Thread Daniele Di Proietto
Hi Ben, I apologize for the delay, I can definitely review this. Thanks, Daniele On 12/10/2015 19:09, "Ben Pfaff" wrote: >Daniele, are you the right person to review this? If not, do you know >who should review it? ___ dev

Re: [ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-10-13 Thread Daniele Di Proietto
Hi Ilya, Sorry for the delay, One question inline On 11/09/2015 12:38, "Ilya Maximets" wrote: >Currently tx_qid is equal to pmd->core_id. This leads to unexpected >behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/', >e.g. if core_ids are not sequential, or

Re: [ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-10-13 Thread Ilya Maximets
On 13.10.2015 18:00, Daniele Di Proietto wrote: >> @@ -2620,9 +2733,20 @@ pmd_load_queues(struct dp_netdev_pmd_thread *pmd, >> poll_list[poll_cnt].rx = port->rxq[i]; >> poll_cnt++; >> } >> -index++; >> +

Re: [ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-10-12 Thread Ben Pfaff
Daniele, are you the right person to review this? If not, do you know who should review it? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-10-02 Thread Ilya Maximets
Ping v2 On 23.09.2015 15:22, Ilya Maximets wrote: > Ping. > > On 11.09.2015 14:38, Ilya Maximets wrote: >> Currently tx_qid is equal to pmd->core_id. This leads to unexpected >> behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/', >> e.g. if core_ids are not sequential, or doesn't start

Re: [ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-09-23 Thread Ilya Maximets
Ping. On 11.09.2015 14:38, Ilya Maximets wrote: > Currently tx_qid is equal to pmd->core_id. This leads to unexpected > behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/', > e.g. if core_ids are not sequential, or doesn't start from 0, or both. > > Example: > starting 2 pmd

[ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-09-11 Thread Ilya Maximets
Currently tx_qid is equal to pmd->core_id. This leads to unexpected behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/', e.g. if core_ids are not sequential, or doesn't start from 0, or both. Example: starting 2 pmd threads with 1 port, 2 rxqs per port, pmd-cpu-mask =