[ovs-dev] [PATCH v5 3/8] lex: Integrate error handling into struct lexer.

2016-08-14 Thread Ben Pfaff
The actions and expr modules had each developed their own error handling code that were very similar. Upcoming code needs similar error handling, so rather than duplicating it again, integrate it into the lexer itself. Signed-off-by: Ben Pfaff Acked-by: Ryan Moats --- include/ovn/actions.h |

Re: [ovs-dev] [PATCH v5 3/8] lex: Integrate error handling into struct lexer.

2016-08-15 Thread Justin Pettit
> On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c > index b56fcd5..b6350ae 100644 > --- a/ovn/lib/actions.c > +++ b/ovn/lib/actions.c > @@ -1,4 +1,4 @@ > -/* > + /* > * Copyright (c) 2015, 2016 Nicira, Inc. My guess is that this change to th

Re: [ovs-dev] [PATCH v5 3/8] lex: Integrate error handling into struct lexer.

2016-08-15 Thread Ben Pfaff
Thanks for all the comments, I fixed all of them. A few responses: On Mon, Aug 15, 2016 at 03:26:05PM -0700, Justin Pettit wrote: > > On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > diff --git a/ovn/lib/lex.c b/ovn/lib/lex.c > > index 95edeaf..a05edfa 100644 > > --- a/ovn/lib/lex.c > > +++ b/o