Re: [ovs-dev] [PATCH_v5 06/26] Move BLDASSERT macros to compiler header file

2016-03-31 Thread Ben Warren
> On Mar 30, 2016, at 4:27 PM, Ben Pfaff wrote: > > On Fri, Mar 25, 2016 at 02:10:25PM -0700, b...@skyportsystems.com wrote: >> From: Ben Warren >> >> Signed-off-by: Ben Warren > > I change the commit message to refer to just "build assertions"; we > don't spell anything as BLDASSERT. > > I

Re: [ovs-dev] [PATCH_v5 06/26] Move BLDASSERT macros to compiler header file

2016-03-30 Thread Ben Pfaff
On Fri, Mar 25, 2016 at 02:10:25PM -0700, b...@skyportsystems.com wrote: > From: Ben Warren > > Signed-off-by: Ben Warren I change the commit message to refer to just "build assertions"; we don't spell anything as BLDASSERT. I don't like comments that define things in terms of history; it make

[ovs-dev] [PATCH_v5 06/26] Move BLDASSERT macros to compiler header file

2016-03-25 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/compiler.h | 30 ++ lib/util.h | 28 2 files changed, 30 insertions(+), 28 deletions(-) diff --git a/include/openvswitch/compiler.h b/include/openvswi