Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-16 Thread Jarno Rajahalme
I posted a v3 of the patch series that includes a fix for this. However, I don’t have the MSVC environment set up, so I’d be grateful if you could test it out. Thanks, Jarno > On Jul 15, 2015, at 5:16 PM, Gurucharan Shetty wrote: > > tomorrow is fine, thank Jarno! > > On Wed, Jul 15, 2015

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Gurucharan Shetty
tomorrow is fine, thank Jarno! On Wed, Jul 15, 2015 at 5:11 PM, Jarno Rajahalme wrote: > I can get on this tomorrow, if a more urgent fix is needed, then the three > patches on the series I pushed should be reverted. > > Jarno > > >> On Jul 15, 2015, at 16:35, Gurucharan Shetty wrote: >> >> O

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Jarno Rajahalme
I can get on this tomorrow, if a more urgent fix is needed, then the three patches on the series I pushed should be reverted. Jarno > On Jul 15, 2015, at 16:35, Gurucharan Shetty wrote: > > One of the patches in this series breaks windows build because of zero > sized array. > https://ci.ap

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Gurucharan Shetty
One of the patches in this series breaks windows build because of zero sized array. https://ci.appveyor.com/project/blp/ovs/build/1.0.458 On Wed, Jul 15, 2015 at 4:01 PM, Jarno Rajahalme wrote: > >> On Jul 14, 2015, at 10:31 PM, Ben Pfaff wrote: >> >> On Fri, Jul 10, 2015 at 10:35:23AM -0700, Ja

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Jarno Rajahalme
> On Jul 14, 2015, at 10:31 PM, Ben Pfaff wrote: > > On Fri, Jul 10, 2015 at 10:35:23AM -0700, Jarno Rajahalme wrote: >> miniflow_clone() and minimask_clone() are no longer used, remove them >> from the API. >> >> Now that miniflow data is always inlined, it makes sense to rename >> miniflow_cl

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-14 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 10:35:23AM -0700, Jarno Rajahalme wrote: > miniflow_clone() and minimask_clone() are no longer used, remove them > from the API. > > Now that miniflow data is always inlined, it makes sense to rename > miniflow_clone_inline() miniflow_clone(). > > Signed-off-by: Jarno Raja

[ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-10 Thread Jarno Rajahalme
miniflow_clone() and minimask_clone() are no longer used, remove them from the API. Now that miniflow data is always inlined, it makes sense to rename miniflow_clone_inline() miniflow_clone(). Signed-off-by: Jarno Rajahalme --- lib/classifier.c|8 lib/flow.c |