Re: [ovs-dev] [RFC PATCH v5] Add support for 802.1ad (QinQ tunneling)

2016-10-26 Thread Eric Garver
Hi Ben and Xiao, One comment below. On Mon, Oct 17, 2016 at 11:15:28AM +0800, Xiao Liang wrote: > Hi Ben, > > Please see inline. > > And another question: > In datapath/README.md: > - If the userspace flow key includes more fields than the > kernel's, for example if userspace decoded an I

Re: [ovs-dev] [RFC PATCH v5] Add support for 802.1ad (QinQ tunneling)

2016-10-16 Thread Xiao Liang
Hi Ben, Please see inline. And another question: In datapath/README.md: - If the userspace flow key includes more fields than the kernel's, for example if userspace decoded an IPv6 header but the kernel stopped at the Ethernet type, then userspace can forward the packet manually, wi

Re: [ovs-dev] [RFC PATCH v5] Add support for 802.1ad (QinQ tunneling)

2016-10-04 Thread Ben Pfaff
On Wed, Sep 14, 2016 at 12:34:36PM +0800, Xiao Liang wrote: > Flow key handleing changes: > - Add VLAN header array in struct flow, to record multiple 802.1q VLAN >headers. > - Add dpif multi-VLAN capability probing. If datapath supports multi-VLAN, >increase the maximum depth of nested O