Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-17 Thread Pravin Shelar
On Fri, Jul 17, 2015 at 3:58 AM, Thomas Graf wrote: > On 07/16/15 at 02:36pm, Pravin Shelar wrote: >> On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf wrote: >> > I'm inclined to change this and use an in-kernel API as well to >> > create the net_device just like VXLAN does in patch 21. >> > >> > Pra

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-17 Thread Thomas Graf
On 07/16/15 at 02:36pm, Pravin Shelar wrote: > On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf wrote: > > I'm inclined to change this and use an in-kernel API as well to > > create the net_device just like VXLAN does in patch 21. > > > > Pravin, what do you think? > > About the vxlan APIs we also ne

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Pravin Shelar
On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf wrote: > On 07/16/15 at 05:59pm, Simon Horman wrote: >> On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: >> > static void ipgre_tap_setup(struct net_device *dev) >> > { >> > ether_setup(dev); >> > - dev->netdev_ops = &gre_tap

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Thomas Graf
On 07/16/15 at 05:59pm, Simon Horman wrote: > On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: > > static void ipgre_tap_setup(struct net_device *dev) > > { > > ether_setup(dev); > > - dev->netdev_ops = &gre_tap_netdev_ops; > > dev->priv_flags |= IFF_LIVE_ADD

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Simon Horman
On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: > From: Pravin Shelar > > Removes all of the OVS specific GRE code and makes OVS use a > GRE net_device. > > Signed-off-by: Pravin B Shelar [snip] > @@ -115,6 +117,8 @@ static bool log_ecn_error = true; > module_param(log_ecn_error

[ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-10 Thread Thomas Graf
From: Pravin Shelar Removes all of the OVS specific GRE code and makes OVS use a GRE net_device. Signed-off-by: Pravin B Shelar --- net/core/dev.c | 5 +- net/ipv4/ip_gre.c | 165 +- net/openvswitch/Makefile | 1 - net/openvswitch/vpor