Thanks for looking again.
I pushed this series without further changes.
On Tue, Feb 15, 2011 at 12:22:16PM -0800, Ethan Jackson wrote:
> Ohh oops, now that I look at it again I misread the code. My bad.
>
> Ethan
>
>
> On Tue, Feb 15, 2011 at 12:17 PM, Ben Pfaff wrote:
> > On Tue, Feb 15, 20
Ohh oops, now that I look at it again I misread the code. My bad.
Ethan
On Tue, Feb 15, 2011 at 12:17 PM, Ben Pfaff wrote:
> On Tue, Feb 15, 2011 at 11:33:42AM -0800, Ethan Jackson wrote:
>> This looks fine to me. However I'm certainty not the worlds best shell
>> programmer.
>>
>> > +
On Tue, Feb 15, 2011 at 11:33:42AM -0800, Ethan Jackson wrote:
> This looks fine to me. However I'm certainty not the worlds best shell
> programmer.
>
> > + elif test "X`ovsdb-tool needs-conversion $conf_file $schema_file`"
> > != Xno; then
> > + # Back up the old version.
> >
This looks fine to me. However I'm certainty not the worlds best shell
programmer.
> + elif test "X`ovsdb-tool needs-conversion $conf_file $schema_file`"
> != Xno; then
> + # Back up the old version.
> + version=`ovsdb-tool db-version "$conf_file"`
> + cksu
On Mon, Feb 14, 2011 at 04:19:42PM -0800, Ethan Jackson wrote:
> I think this is fine. However, we could alternatively always use the
> db-version and the checksum in the backup file name saving the need to
> check if it exists and having the added benefit of consistency. At
> any rate, looks goo
>
> I tested the xenserver version but not the Debian version.
> ---
> debian/openvswitch-switch.init | 13 -
> xenserver/etc_init.d_openvswitch | 15 ---
> 2 files changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/debian/openvswitch-switch.init b/debian/ope
Until now, Open vSwitch "start" has always converted the database to the
current database schema. This compacts the database, which as a side
effect throws away useful information about the transactions that were
executed to bring the database into its current state. This can make
debugging datab
