Re: [ovs-dev] [genl 6/6] dpif-linux: Stop listening for RTNL notifications.

2011-08-26 Thread Ben Pfaff
On Thu, Aug 25, 2011 at 04:28:38PM -0700, Ethan Jackson wrote: Currently dpif-linux listens for vport change events using rtnetlink notifications. This patch switches to the ovs genl notification system. Feature #6809. This looks fine to me. Notifications are often subtle, so I hope that

Re: [ovs-dev] [genl 6/6] dpif-linux: Stop listening for RTNL notifications.

2011-08-26 Thread Ethan Jackson
Thanks for the review. Here is an incremental which I've applied to deal with the deletion of nl_set_mcgroup(). --- lib/dpif-linux.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index 5f52e0b..a9bb36a

Re: [ovs-dev] [genl 6/6] dpif-linux: Stop listening for RTNL notifications.

2011-08-26 Thread Ben Pfaff
On Fri, Aug 26, 2011 at 11:37:54AM -0700, Ethan Jackson wrote: Thanks for the review. Here is an incremental which I've applied to deal with the deletion of nl_set_mcgroup(). Thanks. It looks good. I don't think that open_dpif() can be called if nln is NULL, so the if (nln) in that function

Re: [ovs-dev] [genl 6/6] dpif-linux: Stop listening for RTNL notifications.

2011-08-26 Thread Ethan Jackson
Ah, good point. I removed the check. Ethan On Fri, Aug 26, 2011 at 12:07, Ben Pfaff b...@nicira.com wrote: On Fri, Aug 26, 2011 at 11:37:54AM -0700, Ethan Jackson wrote: Thanks for the review.  Here is an incremental which I've applied to deal with the deletion of nl_set_mcgroup().

[ovs-dev] [genl 6/6] dpif-linux: Stop listening for RTNL notifications.

2011-08-25 Thread Ethan Jackson
Currently dpif-linux listens for vport change events using rtnetlink notifications. This patch switches to the ovs genl notification system. Feature #6809. --- lib/dpif-linux.c | 61 ++ 1 files changed, 43 insertions(+), 18 deletions(-)