Re: [ovs-dev] [manpages 2/5] Implement automatic dependency generation for manpages.

2011-10-26 Thread Ben Pfaff
On Fri, Oct 21, 2011 at 06:42:00PM -0700, Ethan Jackson wrote: Should sodepends.pl be copyright 2008, 2011 as well as 2011? It's derived from soexpand.pl which has a 2008 copyright, so my (imperfect) understanding of the rules is that the earlier copyright year should be retained. I think the

Re: [ovs-dev] [manpages 2/5] Implement automatic dependency generation for manpages.

2011-10-26 Thread Ethan Jackson
This is nastier than it looks at first.  Automake is what does the include processing here (take a look at the generated Makefile in your build directory: it won't have any include directive from this). Automake will error out if an include file is missing.  That means that we need to include

Re: [ovs-dev] [manpages 2/5] Implement automatic dependency generation for manpages.

2011-10-26 Thread Ben Pfaff
On Wed, Oct 26, 2011 at 04:10:14PM -0700, Ethan Jackson wrote: This is nastier than it looks at first. ?Automake is what does the include processing here (take a look at the generated Makefile in your build directory: it won't have any include directive from this). Automake will error out

Re: [ovs-dev] [manpages 2/5] Implement automatic dependency generation for manpages.

2011-10-26 Thread Ben Pfaff
On Wed, Oct 26, 2011 at 04:10:10PM -0700, Ben Pfaff wrote: On Wed, Oct 26, 2011 at 04:10:14PM -0700, Ethan Jackson wrote: This is nastier than it looks at first. ?Automake is what does the include processing here (take a look at the generated Makefile in your build directory: it won't

Re: [ovs-dev] [manpages 2/5] Implement automatic dependency generation for manpages.

2011-10-21 Thread Ethan Jackson
Should sodepends.pl be copyright 2008 as well as 2011? I think the indentation is messed up with the OUTER: loop in sodepends, not sure what the correct style is though so it might be correct. Quick google search was inconclusive. Did you intentionally add manpages.mk to the commit? I would

[ovs-dev] [manpages 2/5] Implement automatic dependency generation for manpages.

2011-08-25 Thread Ben Pfaff
This ensures that manpages actually get rebuilt if any of the lib/*.man fragments that they depend upon are modified. --- Makefile.am| 16 +++- build-aux/sodepends.pl | 69 +++ manpages.mk| 255