[ovs-dev] [ofproto-dpif 5/5] ofproto-dpif: Simplify output action composition.

2011-11-18 Thread Ethan Jackson
This is version of the patch incorporates changes required by modifications to previous patches in the series. force_compose_output_action() changed slightly, I don't think it needs review again. Also, Ben, I'll write up a patch that unit tests this in the next day or so. Justin is blocking on th

Re: [ovs-dev] [ofproto-dpif 5/5] ofproto-dpif: Simplify output action composition.

2011-11-17 Thread Ben Pfaff
On Thu, Nov 17, 2011 at 06:26:55PM -0800, Ethan Jackson wrote: > Before this patch, the logic for outputting to a port was scattered > all around ofproto-dpif. This patch simplifies the code by forcing > it to use one code path to check if a port is forwarding, and > output if appropriate. Future

Re: [ovs-dev] [ofproto-dpif 5/5] ofproto-dpif: Simplify output action composition.

2011-11-17 Thread Ethan Jackson
> This version turned out to be a bit more convenient.  Nothing's different > except the prototype of force_compose_action(). Doh, never mind, this version doesn't work. I'll just go with the first version. Sorry about that. Ethan ___ dev mailing list

[ovs-dev] [ofproto-dpif 5/5] ofproto-dpif: Simplify output action composition.

2011-11-17 Thread Ethan Jackson
This version turned out to be a bit more convenient. Nothing's different except the prototype of force_compose_action(). --- Before this patch, the logic for outputting to a port was scattered all around ofproto-dpif. This patch simplifies the code by forcing it to use one code path to check if

[ovs-dev] [ofproto-dpif 5/5] ofproto-dpif: Simplify output action composition.

2011-11-17 Thread Ethan Jackson
Before this patch, the logic for outputting to a port was scattered all around ofproto-dpif. This patch simplifies the code by forcing it to use one code path to check if a port is forwarding, and output if appropriate. Future patches will rely on this simplification to implement new features. --