Re: [ovs-dev] [tos 1/3] ofproto-dpif: Improperly updates tos and ttl fields.

2011-11-22 Thread Ethan Jackson
> Oh, except that could you make the subject describe the change instead > of the bug, e.g. "ofproto-dpif: Properly update tos and ttl fields." Changed in my local branch. Ethan ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/lis

Re: [ovs-dev] [tos 1/3] ofproto-dpif: Improperly updates tos and ttl fields.

2011-11-22 Thread Ben Pfaff
On Tue, Nov 22, 2011 at 04:56:02PM -0800, Ben Pfaff wrote: > On Tue, Nov 22, 2011 at 04:29:34PM -0800, Ethan Jackson wrote: > > ofproto-dpif failed to update the base flow's tos and ttl fields > > when preparing for an output action. This could cause redundant > > updates of those fields in the da

Re: [ovs-dev] [tos 1/3] ofproto-dpif: Improperly updates tos and ttl fields.

2011-11-22 Thread Ben Pfaff
On Tue, Nov 22, 2011 at 04:29:34PM -0800, Ethan Jackson wrote: > ofproto-dpif failed to update the base flow's tos and ttl fields > when preparing for an output action. This could cause redundant > updates of those fields in the datapath. A future patch adds a > test which could have caught the i

[ovs-dev] [tos 1/3] ofproto-dpif: Improperly updates tos and ttl fields.

2011-11-22 Thread Ethan Jackson
ofproto-dpif failed to update the base flow's tos and ttl fields when preparing for an output action. This could cause redundant updates of those fields in the datapath. A future patch adds a test which could have caught the issue for the tos bits. --- ofproto/ofproto-dpif.c |4 ++-- 1 files