Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Russell Bryant
uot; wrote: - > > > > > > >To: Ben Pfaff > > > >From: Russell Bryant > > > >Sent by: "dev" > > > >Date: 04/12/2016 09:37AM > > > >Cc: ovs dev > > > >Subject: Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Ben Pfaff
On Tue, Apr 12, 2016 at 11:17:30AM -0700, Han Zhou wrote: > On Tue, Apr 12, 2016 at 11:02 AM, Russell Bryant wrote: > > > > On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel > wrote: > > Yes, that's right. I was just assuming that the common case was not > having > > having that many networks, so

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Han Zhou
> >Sent by: "dev" > > >Date: 04/12/2016 09:37AM > > >Cc: ovs dev > > >Subject: Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for > > >ACLs. > > > > > > > >On Mon, Apr 11, 2016 at 12:08 PM, Ben Pfaff wrote: > > &

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Russell Bryant
On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel wrote: > One comment below. > > -"dev" wrote: - > > >To: Ben Pfaff > >From: Russell Bryant > >Sent by: "dev" > >Date: 04/12/2016 09:37AM > >Cc: ovs dev > >Subject:

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Mickey Spiegel
One comment below. -"dev" wrote: - >To: Ben Pfaff >From: Russell Bryant >Sent by: "dev" >Date: 04/12/2016 09:37AM >Cc: ovs dev >Subject: Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for >ACLs. > >On Mon, Apr 11, 2016 at

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Russell Bryant
On Mon, Apr 11, 2016 at 12:08 PM, Ben Pfaff wrote: > On Tue, Apr 05, 2016 at 05:24:19PM -0400, Russell Bryant wrote: > > This feature was originally proposed here: > > > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > > > A common use case for OVN ACLs involves needing to matc

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-11 Thread Ben Pfaff
On Mon, Apr 11, 2016 at 09:08:26AM -0700, Ben Pfaff wrote: > On Tue, Apr 05, 2016 at 05:24:19PM -0400, Russell Bryant wrote: > > This feature was originally proposed here: > > > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > > > A common use case for OVN ACLs involves needing

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-11 Thread Ben Pfaff
On Tue, Apr 05, 2016 at 05:24:19PM -0400, Russell Bryant wrote: > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP > addresses. > >outport == "lp1" && ip4.src

[ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-06 Thread Han Zhou
On Wednesday, April 6, 2016, Russell Bryant > wrote: > > > On Tue, Apr 5, 2016 at 10:03 PM, Han Zhou wrote: > >> >> >> On Tue, Apr 5, 2016 at 2:24 PM, Russell Bryant wrote: >> >> +/* Return true if the address sets match, false otherwise. */ >> > +static bool >> > +address_sets_match(struct addr

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-06 Thread Russell Bryant
On Tue, Apr 5, 2016 at 5:24 PM, Russell Bryant wrote: > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP > addresses. > >outport == "lp1" && ip4.src == {10.0.0.

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-06 Thread Russell Bryant
On Tue, Apr 5, 2016 at 10:03 PM, Han Zhou wrote: > > > On Tue, Apr 5, 2016 at 2:24 PM, Russell Bryant wrote: > >> +/* Return true if the address sets match, false otherwise. */ > > +static bool > > +address_sets_match(struct address_set *addr_set, > > + const struct sbrec_addre

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-05 Thread Han Zhou
On Tue, Apr 5, 2016 at 2:24 PM, Russell Bryant wrote: > > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP > addresses. > >outport == "lp1" && ip4.src == {10.0.0

[ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-05 Thread Russell Bryant
This feature was originally proposed here: http://openvswitch.org/pipermail/dev/2016-March/067440.html A common use case for OVN ACLs involves needing to match a set of IP addresses. outport == "lp1" && ip4.src == {10.0.0.5, 10.0.0.25, 10.0.0.50} This example match only has 3 addresses, bu