Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-09-16 Thread Joe Stringer
On 16 September 2016 at 07:41, David Hill wrote: > Hello guys, > >Our preliminary tests seems to indicate this solves the issue with the > ixgbe driver. My fear is now that other drivers might show the same > behavior. Patching ovs to fallback to ethtool is a good way to

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-09-16 Thread David Hill
Hello guys, Our preliminary tests seems to indicate this solves the issue with the ixgbe driver. My fear is now that other drivers might show the same behavior. Patching ovs to fallback to ethtool is a good way to avoid this imho. Thank you very much, David Hill On 08/31/2016 03:46

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-09-07 Thread David Hill
Sorry for the delay. We got the patched merged in a test kernel and we'll test it asap. Thank you, Dave On 08/31/2016 03:46 PM, Jeff Kirsher wrote: On Tue, 2016-08-30 at 17:35 -0400, David Hill wrote: Hello sir, I do not understand either but that's what's happening. It's a fiber

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-08-31 Thread Jeff Kirsher
On Tue, 2016-08-30 at 17:35 -0400, David Hill wrote: > Hello sir, > > I do not understand either but that's what's happening.  It's a  > fiber adapter so maybe the driver says it's supported and when trying to  > request values from the nic itself it fails because it's no longer  >

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-08-30 Thread David Hill
Hello sir, I do not understand either but that's what's happening. It's a fiber adapter so maybe the driver says it's supported and when trying to request values from the nic itself it fails because it's no longer supported... but that's only a though . Thank you very much, David Hill

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-08-30 Thread Joe Stringer
On 30 August 2016 at 12:49, David Hill wrote: > Hello sir, > >We have a customer hitting an issue where ixgbe will not return an error > at "SIOCGMIIPHY" but will hit it later at "SIOCGMIIREG" so instead of > failling at miimon and never doing the failover, we'd like it to

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-08-30 Thread David Hill
Hello sir, We have a customer hitting an issue where ixgbe will not return an error at "SIOCGMIIPHY" but will hit it later at "SIOCGMIIREG" so instead of failling at miimon and never doing the failover, we'd like it to use ethtool which is properly returning the link state. Thank you

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-08-30 Thread Joe Stringer
On 30 August 2016 at 12:21, David Hill wrote: > > Can you explain what you're trying to achieve with this patch? * What is the behaviour * Environment * How this patch fixes the issue ___ dev mailing list dev@openvswitch.org

[ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

2016-08-30 Thread David Hill
Subject: bug fix for miimon issue with ixgbe driver that half support mii diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index efc9527..05aa91f 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -1426,6 +1426,33 @@ netdev_linux_do_miimon(const char *name, int cmd, const char