Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

2016-04-22 Thread William Tu
Hi Ben, Thank you! I will continue working on other fixes. Regards, William On Fri, Apr 22, 2016 at 5:05 PM, Ben Pfaff wrote: > I sent a series that should fix this deadlock. You can still fix (or > report) others! > > http://openvswitch.org/pipermail/dev/2016-April/070055.html

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

2016-04-22 Thread Ben Pfaff
I sent a series that should fix this deadlock. You can still fix (or report) others! http://openvswitch.org/pipermail/dev/2016-April/070055.html http://openvswitch.org/pipermail/dev/2016-April/070056.html On Tue, Apr 12, 2016 at 10:05:36PM -0700, William Tu wrote: > Let me take a stab at them

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

2016-04-12 Thread William Tu
Let me take a stab at them first, if I couldn't figure out, I will pass them along. Thanks On Tue, Apr 12, 2016 at 9:09 PM, Ben Pfaff wrote: > On Tue, Apr 12, 2016 at 02:39:49PM -0700, William Tu wrote: > > Hi Ben, > > > > Thanks, the fix solves the problem. > > > > However, there

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

2016-04-12 Thread Ben Pfaff
On Tue, Apr 12, 2016 at 02:39:49PM -0700, William Tu wrote: > Hi Ben, > > Thanks, the fix solves the problem. > > However, there are a couple of errors reported by Helgrind, do you think > it's worth fixing all of them? Probably. Do you want to pass them along for me to take a look? Or do you

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

2016-04-12 Thread William Tu
Hi Ben, Thanks, the fix solves the problem. However, there are a couple of errors reported by Helgrind, do you think it's worth fixing all of them? Regards, William On Sun, Apr 10, 2016 at 2:16 PM, Ben Pfaff wrote: > On Wed, Feb 24, 2016 at 12:40:33PM -0800, William Tu wrote:

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

2016-04-10 Thread Ben Pfaff
On Wed, Feb 24, 2016 at 12:40:33PM -0800, William Tu wrote: > These two locks are reported by helgrind which have ordering inconsistency. > "netdev_class_mutex" > "route_table_mutex" > http://openvswitch.org/pipermail/discuss/2016-February/020216.html Thanks for the report. Somehow I didn't get