[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #28: Cdi parameter resolver

rmannibucau commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439796487 ## File path: webbeans-junit5/src/test/java/org/apache/openwebbeans/junit5/parameter/ParameterResolutionTest.java ## @@ -0,0 +1,35 @@ +/* + * Licens

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #28: Cdi parameter resolver

rmannibucau commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439796451 ## File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/internal/CdiExtension.java ## @@ -172,4 +182,76 @@ private void doClose(f

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #28: Cdi parameter resolver

rmannibucau commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439796243 ## File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/internal/CdiExtension.java ## @@ -172,4 +182,76 @@ private void doClose(f

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #28: Cdi parameter resolver

rmannibucau commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439796088 ## File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/Cdi.java ## @@ -80,6 +80,11 @@ */ boolean disableDiscovery() de

[GitHub] [openwebbeans] philippkunz commented on a change in pull request #28: Cdi parameter resolver

philippkunz commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439770518 ## File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/internal/CdiExtension.java ## @@ -172,4 +182,76 @@ private void doClose(f

[GitHub] [openwebbeans] philippkunz commented on a change in pull request #28: Cdi parameter resolver

philippkunz commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439770221 ## File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/internal/CdiExtension.java ## @@ -172,4 +182,76 @@ private void doClose(f

[GitHub] [openwebbeans] philippkunz commented on a change in pull request #28: Cdi parameter resolver

philippkunz commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439769304 ## File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/Cdi.java ## @@ -80,6 +80,11 @@ */ boolean disableDiscovery() de

[GitHub] [openwebbeans] philippkunz commented on a change in pull request #28: Cdi parameter resolver

philippkunz commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439769215 ## File path: webbeans-junit5/pom.xml ## @@ -76,17 +76,9 @@ default-test -

[GitHub] [openwebbeans] philippkunz opened a new pull request #28: Cdi parameter resolver

philippkunz opened a new pull request #28: URL: https://github.com/apache/openwebbeans/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

Then not sure which place you have in mind to fail? An alternative could have been to do exclusions on the url.tostring but it would break current existing apps which is not an option for this thing IMHO. Do you have anything in mind? Romain Manni-Bucau @rmannibucau

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

No, we did have File in OWB-1.0 and 1.1. And killed that because we got problems because not all classpath elemts are file based. Examples are some app servers which have even some internal protocols. like webjar for example in EARs in WebLogic (yes, there are some peeps who use OWB in weblogic,

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

Yes and no IMHO. Strictly speaking you are perfectly right, org.apache.webbeans.corespi.scanner.AbstractMetaDataDiscovery#registerBeanArchives should handle File and not URL and do the filtering there (and fail if needed) but org.apache.webbeans.corespi.scanner.AbstractMetaDataDiscovery#filterExc

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

> Am 13.06.2020 um 19:37 schrieb Romain Manni-Bucau : > >> e.2) >> if (file == null) { >>throw new IllegalArgumentException( >> Why? Let's log a WARN, but why blow up? xbean only supports jar: and file: >> protocols. Anything other will just not be excluded. So what? >> > > Blow up cause w

[jira] [Resolved] (OWB-1329) Remove openwebbeans-maven module

[ https://issues.apache.org/jira/browse/OWB-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved OWB-1329. - Resolution: Fixed > Remove openwebbeans-maven module > > >

[jira] [Resolved] (MEECROWAVE-248) Upgrade to Log4j 2.13.3

[ https://issues.apache.org/jira/browse/MEECROWAVE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved MEECROWAVE-248. --- Resolution: Fixed > Upgrade to Log4j 2.13.3 > --- > >

[jira] [Resolved] (MEECROWAVE-247) Upgrade to Johnzon 1.2.7

[ https://issues.apache.org/jira/browse/MEECROWAVE-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved MEECROWAVE-247. --- Resolution: Fixed > Upgrade to Johnzon 1.2.7 > -

[jira] [Resolved] (MEECROWAVE-246) Upgrade to OpenWebbeans 2.0.17

[ https://issues.apache.org/jira/browse/MEECROWAVE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved MEECROWAVE-246. --- Resolution: Fixed > Upgrade to OpenWebbeans 2.0.17 >

[jira] [Resolved] (MEECROWAVE-249) Upgrade to OpenJPA 3.1.1

[ https://issues.apache.org/jira/browse/MEECROWAVE-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved MEECROWAVE-249. --- Resolution: Fixed > Upgrade to OpenJPA 3.1.1 > >

[jira] [Created] (OWB-1329) Remove openwebbeans-maven module

Romain Manni-Bucau created OWB-1329: --- Summary: Remove openwebbeans-maven module Key: OWB-1329 URL: https://issues.apache.org/jira/browse/OWB-1329 Project: OpenWebBeans Issue Type: Task

[jira] [Created] (MEECROWAVE-249) Upgrade to OpenJPA 3.1.1

Romain Manni-Bucau created MEECROWAVE-249: - Summary: Upgrade to OpenJPA 3.1.1 Key: MEECROWAVE-249 URL: https://issues.apache.org/jira/browse/MEECROWAVE-249 Project: Meecrowave Issue T

[jira] [Created] (MEECROWAVE-248) Upgrade to Log4j 2.13.3

Romain Manni-Bucau created MEECROWAVE-248: - Summary: Upgrade to Log4j 2.13.3 Key: MEECROWAVE-248 URL: https://issues.apache.org/jira/browse/MEECROWAVE-248 Project: Meecrowave Issue Ty

[jira] [Created] (MEECROWAVE-247) Upgrade to Johnzon 1.2.7

Romain Manni-Bucau created MEECROWAVE-247: - Summary: Upgrade to Johnzon 1.2.7 Key: MEECROWAVE-247 URL: https://issues.apache.org/jira/browse/MEECROWAVE-247 Project: Meecrowave Issue

[jira] [Created] (MEECROWAVE-246) Upgrade to OpenWebbeans 2.0.17

Romain Manni-Bucau created MEECROWAVE-246: - Summary: Upgrade to OpenWebbeans 2.0.17 Key: MEECROWAVE-246 URL: https://issues.apache.org/jira/browse/MEECROWAVE-246 Project: Meecrowave I

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

Le sam. 13 juin 2020 à 19:29, Mark Struberg a écrit : > Wow, there are sooo many different things going on. > > a.) also -1 for 'obvious' - nearly redundant - docs. > > b.) In Geronimo there are about 5..7 active folks. Plus the people from > the TomEE project which do reviews and give precious f

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

Wow, there are sooo many different things going on. a.) also -1 for 'obvious' - nearly redundant - docs. b.) In Geronimo there are about 5..7 active folks. Plus the people from the TomEE project which do reviews and give precious feedback. c.) In OWB we also had lots of active people: Romain, T

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

+1 in general, Gurkan however, we should focus on the most important things only everyone of us is working on many OS projects and its quite hard to write many docu as its very time consuming. i would like to have at least docus on class level (we can also skip them if the class is a POJO or no br

Re: Cdi Parameter Injection

Hi Philipp, A few notes: 1. You can do PR on github if it helps 2. I'd cache the resolution of supports (if true) to reuse it to get the instance, speeds up things in a suite 3. We need a @CdiInjection marker (whatever name) otherwise we can break injections for things which are beans but also in

Cdi Parameter Injection

Hi, Wouldn't it be nice, if CDI would also resolve method parameters? See patch. Regards, Philipp diff --git a/webbeans-junit5/pom.xml b/webbeans-junit5/pom.xml index 23f18161b..0e0807621 100644 --- a/webbeans-junit5/pom.xml +++ b/webbeans-junit5/pom.xml @@ -76,17 +76,9 @@

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

Updated this fix by failing if url is null with a message saying to either change the scanner or add the file to exclusions. Can anyone review it please before next release (2.0.18)? Romain Manni-Bucau @rmannibucau | Blog | Old

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

> > This is wrong, what does make you think that? I know you left for a very > long time and missed quite a lot of things I have been following most of the mailing lists even if I am not able to contribute. but typically most of xbean is > not decided by these 3 people but was decided way earlie

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

Le sam. 13 juin 2020 à 10:54, Gurkan Erdogdu a écrit : > If you want to revert , you can... > But Xbean method returns null and throwing NPE is not a good way to go... > Contract makes it respected. If you run in another env you setup another impl. Side note being ignoring silently an error is w

Re: [openwebbeans] branch master updated: OWB-1328 NPE in AbstractMetaDataFactory

If you want to revert , you can... But Xbean method returns null and throwing NPE is not a good way to go... >From my understanding looking to those projects and even OWB, most of the decisions in these projects are only decided by one or two persons(probably internally) but not with the community

Re: [VOTE][RESULT] Release Apache OpenWebBeans-2.0.17

Hi! Sorry for taking a bit longer. With my own +1 we got the following VOTE result: +1: Daniel, Romain, Gurkan, Reinhard, Mark I'll continue with the release process. txs and LieGrue, strub > Am 07.06.2020 um 23:30 schrieb Mark Struberg : > > hi! > > I'd like to call a VOTE on releasing A