Re: EJB contextual reference (our proxy) in creationalContext instead of instance?

2010-07-18 Thread Eric Covener
(ClassUtil.java:533) at org.apache.webbeans.ejb.common.component.BaseEjbBean.destroyComponentInstance(BaseEjbBean.java:149) at org.apache.webbeans.component.AbstractInjectionTargetBean.destroyInstance(AbstractInjectionTargetBean.java:179) -- Eric Covener cove...@gmail.com

... then no parameters are passed to the method by the container

2010-07-18 Thread Eric Covener
(whose signature has parameters) called by the application? -- Eric Covener cove...@gmail.com

EJB contextual reference (our proxy) in creationalContext instead of instance?

2010-07-17 Thread Eric Covener
(WebContextsService.java:333) at org.apache.webbeans.web.context.WebContextsService.endContext(WebContextsService.java:169) -- Eric Covener cove...@gmail.com

Re: svn commit: r934161 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans: component/ container/ context/ context/creational/ decorator/ event/ inject/ intercept/ portable/cre

2010-07-16 Thread Eric Covener
@@ -125,13 +152,16 @@ public class CreationalContextImplT im      * @param dependent dependent contextual      * @param instance dependent instance      */ -    public K void addDependent(ContextualK dependent, Object instance, CreationalContextK cc) +    public K void addDependent(Object

Re: ejb local interface types

2010-07-15 Thread Eric Covener
On Thu, Jul 15, 2010 at 2:47 AM, David Blevins david.blev...@visi.com wrote: On Jul 14, 2010, at 9:44 AM, Eric Covener wrote: I'm doing some  work with a non-openejb EJB container and looking at the base and openejb-specific logic OpenEJBBean.java:    public ListMethod getRemoveMethods

Re: svn commit: r959733 - in /openwebbeans/trunk/webbeans-openejb/src: main/java/org/apache/webbeans/ejb/ main/java/org/apache/webbeans/ejb/resource/ test/java/org/apache/webbeans/ejb/

2010-07-15 Thread Eric Covener
or an SFSB? Is it as simple as making sure none of them return true before removing deployed app? -- Eric Covener cove...@gmail.com

ejb local interface types

2010-07-14 Thread Eric Covener
we used to find the managed bean, or the one we used to get a reference from JNDI) -- Eric Covener cove...@gmail.com

Re: [VOTE] 2nd try: release Apache OpenWebBeans-1.0.0-alpha-1

2010-07-06 Thread Eric Covener
Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-035/org/apache/openwebbeans/openwebbeans/1.0.0-alpha-1/openwebbeans-1.0.0-alpha-1-source-release.zip +1 for alpha, thanks for RM'ing Mark! -- Eric Covener cove...@gmail.com

Re: [VOTE] release Apache OpenWebBeans-1.0.0-alpha-1

2010-07-04 Thread Eric Covener
On Sat, Jul 3, 2010 at 4:32 PM, Mark Struberg strub...@yahoo.de wrote: Vote will be open for 72 hours. If we don't re-spin for Gurkans concerns, can we keep the vote open into Tuesday/Wednesday? We have a U.S. holiday Monday. -- Eric Covener cove...@gmail.com

Re: svn commit: r960249 - in /openwebbeans/trunk: ./ atinject-tck/ samples/ samples/conversation-sample/ samples/ejb-sample/ samples/ejb-telephone/ samples/guess/ samples/jms-sample/ samples/jsf2sam

2010-07-03 Thread Eric Covener
-        version1.0.0-SNAPSHOT/version +        version1.0.0-alpha-1/version I'm new to maven, why doesn't this release prep occur on a branch? -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-401) ELContextStore not cleaned up for some JSP EL lookups

2010-06-23 Thread Eric Covener (JIRA)
: Injection and Lookup Affects Versions: M4 Environment: jetty + guess sample + simple dependent bean + jsp Reporter: Eric Covener Assignee: Gurkan Erdogdu Playing with the guess sample with an added dependent bean and a JSP with a simple EL expression referencing

[jira] Commented: (OWB-401) ELContextStore not cleaned up for some JSP EL lookups

2010-06-23 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881979#action_12881979 ] Eric Covener commented on OWB-401: -- As I now understand it, the piece were missing is finding

Re: problems with lack of archive-centric BeanManager

2010-06-20 Thread Eric Covener
don't think we fulfill the spec with regards to enabling interceptors and decorators (and probably alternatives) on a BDA-by-BDA basis. -- Eric Covener cove...@gmail.com

Re: [VOTE] release openwebbeans build-tools-1.0.0

2010-06-17 Thread Eric Covener
On Wed, Jun 16, 2010 at 1:25 PM, Mark Struberg strub...@yahoo.de wrote: Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-057/org/apache/openwebbeans/build-tools/checkstyle-rules/1.0.0/checkstyle-rules-1.0.0-source-release.zip +1 for release -- Eric

[jira] Created: (OWB-398) DelegateHandler cached too agressively

2010-06-17 Thread Eric Covener (JIRA)
Versions: M4 Reporter: Eric Covener Assignee: Eric Covener The InterceptorHandler and OpenWebbeansEJBinterceptor keep the interceptor that hooks the decorator stack in the cached interceptor stack. This can lead to an incorrect delegate handler being used

[jira] Resolved: (OWB-398) DelegateHandler cached too agressively

2010-06-17 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-398. -- Fix Version/s: 1.0.0-CR1 Resolution: Fixed http://svn.apache.org/viewvc?rev=955801view=rev (tagged

problems with lack of archive-centric BeanManager

2010-06-15 Thread Eric Covener
bean based on the BDA it comes from ) interceptor being run. -- Eric Covener cove...@gmail.com

pre_passivate/post_activate lifecycle callbacks

2010-05-26 Thread Eric Covener
I see some of this related code is commented out in InterceptorUtil -- what's the background here? -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-378) ejb at bottom of decorator stack doesn't handle changed method

2010-05-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-378. -- Resolution: Fixed ejb at bottom of decorator stack doesn't handle changed method

ejb interceptor ordering

2010-05-19 Thread Eric Covener
-in-ejb-bean-class would remain last: @Interceptors, @InterceptorBinding, defined-in-ejb-bean-class, But I think the current tomcat/ejb integration implements it the other way: @Interceptors, defined-in-ejb-bean-class, @InterceptorBinding Any opinions/interpretations? -- Eric Covener cove...@gmail.com

tck artifacts not resolving?

2010-05-14 Thread Eric Covener
My sandbox is unable to find org.jboss.jsr299.tck:jsr299-tck-api:jar:1.0.2-SNAPSHOT I manually poked around jboss'es repository and only saw what looked like very old TCK artifacts. I mostly bluff my way through maven, but is -porting building for anyone else? -- Eric Covener cove

[jira] Created: (OWB-371) no lifecycle interceptors for non-contextual EJB

2010-05-13 Thread Eric Covener (JIRA)
and Decorators Affects Versions: M4 Reporter: Eric Covener Assignee: Gurkan Erdogdu The current OpenWebBeansEjbInterceptor only does work in its postConstruct/preDestroy when the EJB was contextual. -- This message is automatically generated by JIRA. - You can reply

[jira] Commented: (OWB-371) no lifecycle interceptors for non-contextual EJB

2010-05-13 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12867298#action_12867298 ] Eric Covener commented on OWB-371: -- I wasn't sure about the proper behavior, but 7.2 says

[jira] Created: (OWB-372) creational context not cleaned up for non-contextual EJB interceptions

2010-05-13 Thread Eric Covener (JIRA)
: Bug Components: Interceptor and Decorators Affects Versions: M4 Reporter: Eric Covener Assignee: Gurkan Erdogdu we create a null CC in the OWBEJB interceptor, but it's never stashed away to be cleaned up during e.g. preDestroy -- This message

[jira] Created: (OWB-365) make injection optional in OWBEJBInterceptor

2010-04-28 Thread Eric Covener (JIRA)
and Lookup, Interceptor and Decorators Affects Versions: M4 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.0.0 the injection portion of the @PostConstruct callback in the OWBEJBInterceptor should be suppressable via

dist-sources.xml question

2010-04-23 Thread Eric Covener
/useDefaultExcludes outputDirectorysrc/outputDirectory excludes -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-361) underlying EJB method not actually in our interceptors stack

2010-04-23 Thread Eric Covener (JIRA)
Components: Interceptor and Decorators Affects Versions: M4 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor When the OWBEjbInterceptor is hooked into an EJB interceptor stack, and the final 299 interceptor calls context.proceed(), they don't see

Fwd: [jira] Commented: (OWB-359) ownerCreationalContext sometimes causes NPE in InterceptorDataImpl.createNewInstance()

2010-04-21 Thread Eric Covener
Bounced first time using cove...@a.o as sender in gmail -- Forwarded message -- From: Eric Covener cove...@apache.org Date: Wed, Apr 21, 2010 at 11:31 AM Subject: Fwd: [jira] Commented: (OWB-359) ownerCreationalContext sometimes causes NPE

[jira] Created: (OWB-357) WebbeansFinder should index first on ClassLoader, not singleton type

2010-04-15 Thread Eric Covener (JIRA)
Affects Versions: M4 Environment: tiered classloader Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: M4 I'm finding WebbeansFinder a little difficult to work with since it is unable to easily clear all instances

Re: svn commit: r932843 - in /openwebbeans/trunk/webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common: component/BaseEjbBean.java interceptor/OpenWebBeansEjbInterceptor.java proxy/EjbBeanProxyH

2010-04-11 Thread Eric Covener
workspace yet, but who is calling the BaseEJBBean.setThreadLocal() ? Finally, does this work whether or not the EJB itself was contextual? -- Eric Covener cove...@gmail.com

switching between web and standalone TCK

2010-03-24 Thread Eric Covener
What is required to switch between the two modes of the TCK? I only get approximately 509 tests either way, and i thought the web profile # was supposed to be larger. -- Eric Covener cove...@gmail.com

Re: JSR-299 based interceptors and decorators are not supported for EJB Beans

2010-03-24 Thread Eric Covener
is in a bean archive, or always? The last bullet for interceptor/decorator resoluton is not 100% clear wrt EJB. -- Eric Covener cove...@gmail.com

Re: svn commit: r923435 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans: component/ component/creation/ config/ container/ decorator/ intercept/ portable/events/discovery/ u

2010-03-23 Thread Eric Covener
(WebBeansConfigurationListener.java:66) It finally occurred to me how/why this backtrace doesn't make any sense. Any idea on how I can be getting from AbstractInjectionTargetBean to AbstractBeanCreator (instead of AbstractOWBBean which just access a priave field) in my TCK env? -- Eric Covener

Re: svn commit: r923435 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans: component/ component/creation/ config/ container/ decorator/ intercept/ portable/events/discovery/ u

2010-03-23 Thread Eric Covener
On Tue, Mar 23, 2010 at 9:26 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: This seems to be an old code. Did you checkout latest code from trunk? yes, but I will scrap my sandbox and re-scrap my ~/.m2 -- thanks for looking. -- Eric Covener cove...@gmail.com

Re: svn commit: r923435 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans: component/ component/creation/ config/ container/ decorator/ intercept/ portable/events/discovery/ u

2010-03-20 Thread Eric Covener
(WebContainerLifecycle.java:75) at org.apache.webbeans.servlet.WebBeansConfigurationListener.contextInitialized(WebBeansConfigurationListener.java:66) I am arbitrarily onorg.jboss.jsr299.tck.tests.extensions.producer.ProducerTest.testDisposeDoesNothing -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-03-09 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-318. -- Resolution: Fixed duplicate @Interceptors in a managed bean now share an instance of the interceptor

Re: [VOTE] Release OpenWebBeans-M4

2010-03-01 Thread Eric Covener
On Mon, Mar 1, 2010 at 3:52 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Hi; Finally  release time  :) This is the OpenWebBeans M4 release [VOTE] process. Any pointers on testing the staged OWB release for the maven-impaired? -- Eric Covener cove...@gmail.com

Re: svn commit: r916942 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InvocationContextImpl.java

2010-02-27 Thread Eric Covener
On Sat, Feb 27, 2010 at 6:36 AM, gerdo...@apache.org wrote: +                               //First change to wrapper for comparision +                               parameterType = ClassUtil.getPrimitiveWrapper(parameterType); +1, didn't know abou that in ClassUtil! -- Eric Covener cove

Re: TCK Report Before M4

2010-02-27 Thread Eric Covener
On Fri, Feb 26, 2010 at 3:46 PM, Eric Covener cove...@gmail.com wrote: On Wed, Feb 24, 2010 at 2:39 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Please do not commit big changes to current code base. I will start to release procedure by tomorrow evening maybe Saturday. Total Test

Re: interceptor API TCK/maven question

2010-02-26 Thread Eric Covener
for the tip! -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-311) @ExcludeClassInterceptors doesn't remove in all cases

2010-02-26 Thread Eric Covener (JIRA)
: Interceptor and Decorators Affects Versions: M3 Reporter: Eric Covener Assignee: Eric Covener Fix For: M4 Conditions in @ExcludeClassInterceptors seems unnecessarily complicated, and doesn't properly remove class-level interceptors on methods

[jira] Resolved: (OWB-311) @ExcludeClassInterceptors doesn't remove in all cases

2010-02-26 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-311. -- Resolution: Fixed @ExcludeClassInterceptors doesn't remove in all cases

[jira] Created: (OWB-306) overrridden @AroundInvoke and lifecycle interceptors are still run

2010-02-25 Thread Eric Covener (JIRA)
Affects Versions: M3 Reporter: Eric Covener Assignee: Eric Covener Fix For: 1.0.0 Interceptor spec says: --- If an around-invoke method is overridden by another method (regardless of whether that method is itself an around-invoke method

[jira] Created: (OWB-307) InvocationContext.setParameters() and primitive vs. wrapped types

2010-02-25 Thread Eric Covener (JIRA)
Affects Versions: M3 Reporter: Eric Covener Assignee: Gurkan Erdogdu Fix For: 1.0.0 right now setParameters() on a method with primtiive types does not permit the wrapped types to be set. -- This message is automatically generated by JIRA. - You can reply

[jira] Created: (OWB-309) signature check for @Interceptors-enabled interceptors is too strict

2010-02-25 Thread Eric Covener (JIRA)
Components: Interceptor and Decorators Affects Versions: M3 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: M4 Sometimes having the wrong kind of signature (defined in bean class vs. defined in an interceptor

[jira] Resolved: (OWB-271) method-level interceptor bindings not inherited properly

2010-02-16 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-271. -- Resolution: Fixed Fix Version/s: (was: 1.0.0) M4 method-level interceptor

[jira] Resolved: (OWB-266) transitive interceptor bindings not applied to Bean subclasses

2010-02-16 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-266. -- Resolution: Fixed Fix Version/s: (was: 1.0.0) M4 transitive interceptor

Re: transitive interceptor bindings

2010-02-05 Thread Eric Covener
and all its transitive interceptors @Binding2 and @Binding3. Your patch seems to handle problem this way. Thanks for the review, I'll wait until after M4 is branched and commit. -- Eric Covener cove...@gmail.com

transitive interceptor bindings

2010-02-04 Thread Eric Covener
. Is the @Inherited on the inner/nested binding types really not a factor here? Thanks, -- Eric Covener cove...@gmail.com

Re: transitive interceptor bindings

2010-02-04 Thread Eric Covener
for @Inherited. -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-266) transitive interceptor bindings not applied to Bean subclasses

2010-02-04 Thread Eric Covener (JIRA)
Components: Interceptor and Decorators Affects Versions: M3 Reporter: Eric Covener Assignee: Eric Covener Fix For: 1.0.0 Attachments: transitive_subclass.diff For @Inherited InterceptorBinding A that has transitive bindings X,Y declared: X and Y

[jira] Commented: (OWB-266) transitive interceptor bindings not applied to Bean subclasses

2010-02-04 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829886#action_12829886 ] Eric Covener commented on OWB-266: -- eek, X and Y intercept a class annotated

[jira] Created: (OWB-255) injection point errors at deployment don't tell you the injection point!

2010-01-27 Thread Eric Covener (JIRA)
Type: Improvement Components: Injection and Lookup Affects Versions: M3 Reporter: Eric Covener Assignee: Eric Covener Priority: Trivial If you have an unsatisfiable or ambiguous injection detected during ResolutionUtil.checkResolvedBeans

[jira] Resolved: (OWB-232) exceptions with non-OWB XML don't contain interceptor/decorator classnames

2010-01-15 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-232. -- Resolution: Fixed exceptions with non-OWB XML don't contain interceptor/decorator classnames

<    1   2