[jira] Closed: (OWB-116) Update Business Method Definition

2010-04-11 Thread Gurkan Erdogdu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gurkan Erdogdu closed OWB-116.
--

Resolution: Fixed

Already done.

 Update Business Method Definition
 -

 Key: OWB-116
 URL: https://issues.apache.org/jira/browse/OWB-116
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Lifecycle
Affects Versions: M3
Reporter: Gurkan Erdogdu
Assignee: Gurkan Erdogdu
Priority: Minor
 Fix For: 1.0.0


 See section, 7.2. Decorator and Interceotor method calls are not activate 
 interceptors and decorators.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (OWB-349) ignore exception during type hierarchy scan

2010-04-11 Thread Mario Ivankovits (JIRA)
ignore exception during type hierarchy scan
---

 Key: OWB-349
 URL: https://issues.apache.org/jira/browse/OWB-349
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Core
Affects Versions: 1.0.0
 Environment: JDK 1.6.0_17
Reporter: Mario Ivankovits
Assignee: Gurkan Erdogdu
 Attachments: invalid_superclass_type.patch

During classpath scan OWB crashes with an MalformedParameterizedTypeException 
exception.

This exception happens in ClassUtils.setTypeHierarchy when trying to get the 
GenericSuperclass.

It seems I can not fix this exception on my side as the code compiles and works 
fine and the class I inherit from is a class of a used library.

I think the system should not fail anyway. A warning that a type needs to be 
ignored should be enough ...


Attached is a patch which makes OWB correctly startup here by doing so.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Closed: (OWB-349) ignore exception during type hierarchy scan

2010-04-11 Thread Gurkan Erdogdu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gurkan Erdogdu closed OWB-349.
--

Fix Version/s: 1.0.0
   Resolution: Fixed

Done, thanks Mario Ivankovits

 ignore exception during type hierarchy scan
 ---

 Key: OWB-349
 URL: https://issues.apache.org/jira/browse/OWB-349
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Core
Affects Versions: 1.0.0
 Environment: JDK 1.6.0_17
Reporter: Mario Ivankovits
Assignee: Gurkan Erdogdu
 Fix For: 1.0.0

 Attachments: invalid_superclass_type.patch


 During classpath scan OWB crashes with an 
 MalformedParameterizedTypeException exception.
 This exception happens in ClassUtils.setTypeHierarchy when trying to get the 
 GenericSuperclass.
 It seems I can not fix this exception on my side as the code compiles and 
 works fine and the class I inherit from is a class of a used library.
 I think the system should not fail anyway. A warning that a type needs to be 
 ignored should be enough ...
 Attached is a patch which makes OWB correctly startup here by doing so.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: svn commit: r932843 - in /openwebbeans/trunk/webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common: component/BaseEjbBean.java interceptor/OpenWebBeansEjbInterceptor.java proxy/EjbBeanProxyH

2010-04-11 Thread Eric Covener
 +    private Object callInterceptorsAndDecorators(Method method, Object 
 instance, Object[] arguments) throws Exception

Do you think it's possible to re-use an InterceptorHandler instead of
having the ejb-common code know so much detail of
interceptors/decorators?

I wasn't able to rebase my workspace yet, but who is calling the
BaseEJBBean.setThreadLocal() ?

Finally, does this work whether or not the EJB itself was contextual?

-- 
Eric Covener
cove...@gmail.com


Re: svn commit: r932843 - in /openwebbeans/trunk/webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common: component/BaseEjbBean.java interceptor/OpenWebBeansEjbInterceptor.java proxy/EjbBeanProxyH

2010-04-11 Thread Gurkan Erdogdu
Do you think it's possible to re-use an InterceptorHandler instead of
having the ejb-common code know so much detail of
interceptors/decorators?
Hımm, the first reason is that in EJB scenario, target bean method is called by 
the EJB container. Second is that InterceptorHandler is a Javassist method 
handler, the other is interceptor. But it is reasonable to define common 
methods that are used by both of them.

I wasn't able to rebase my workspace yet, but who is calling the
BaseEJBBean.setThreadLocal() ?
It is called by the EjbBeanProxyHandler#invoke

Finally, does this work whether or not the EJB itself was contextual?
This is written to work with contextual EJB beans. If the EJB bean is not 
contextual, then it does not support decorators but supports JSR299 style
interceptors. We could create a new EJB interceptor/utility for returning 
interceptors for non-contextual ejbs.

Thanks;

--Gurkan




From: Eric Covener cove...@gmail.com
To: dev@openwebbeans.apache.org
Sent: Sun, April 11, 2010 2:35:11 PM
Subject: Re: svn commit: r932843 - in 
/openwebbeans/trunk/webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common:  
component/BaseEjbBean.java interceptor/OpenWebBeansEjbInterceptor.java  
proxy/EjbBeanProxyHandler.java util/EjbDefinitionUtility.java

 +private Object callInterceptorsAndDecorators(Method method, Object 
 instance, Object[] arguments) throws Exception

Do you think it's possible to re-use an InterceptorHandler instead of
having the ejb-common code know so much detail of
interceptors/decorators?

I wasn't able to rebase my workspace yet, but who is calling the
BaseEJBBean.setThreadLocal() ?

Finally, does this work whether or not the EJB itself was contextual?

-- 
Eric Covener
cove...@gmail.com



  ___
Yahoo! Türkiye açıldı!  http://yahoo.com.tr
İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!

Fwd: OWB integration with OpenEJB Tomcat Integration Code

2010-04-11 Thread Gurkan Erdogdu
FYI

-- Forwarded message --
From: Gurkan Erdogdu cgurkanerdo...@gmail.com
Date: 2010/4/11
Subject: OWB integration with OpenEJB Tomcat Integration Code
To: d...@openejb.apache.org


Hello folks;

I have started to integrate OpenWebBeans into OpenEJB+Tomcat integration
code. I mainly use and update following modules

- openejb-tomcat-catalina
- openejb-tomcat-loader
- openejb-tomcat-webapp

FYI, I have already integrated OWB with Apache Tomcat 6, therefore no need
to define any configuration files to use OWB in Tomcat. Currently, OWB also
supports OpenEJB in Tomcat but developer has to manage configuration files
(adding OpenWebBeansEJBInterceptor to every beans) and library dependencies.


Main point for this integration is to relief developers from burden of
configuration issues.

What I am currently doing

1- Adding more comments for those modules. Currently, those modules do not
contain so much comment and it is hard to understand code without comments.
I understood the code finally with time consuming and not want any other
developer have troubles with the same experience.

2- Update openejb-tomcat-webapp to add OpenWebBeans specific libraries in
the resulting war. there are two sections here, one for adding libraries to
Catalina ClassLoader (adding owb-api, spi etc.) and one for adding libraries
into users web application's class loaders (owb-impl, owb-web etc.)

3- Update TomcatWebBuilder for adding Context Listener to web applications
and adding OpenWebBeansEJB interceptor to ejb beans (If web module has
WEB-INF/beans.xml)

If I successful on getting working code, there is need to configure anything
to run OWB with OpenEJB and Tomcat. just packages web applications with
WEB-INF/beans.xml.

Thanks;

--Gurkan




-- 
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com


[jira] Closed: (OWB-350) Support Interceptor for non-contextual EJBs

2010-04-11 Thread Gurkan Erdogdu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gurkan Erdogdu closed OWB-350.
--

Resolution: Fixed

 Support Interceptor for non-contextual EJBs
 ---

 Key: OWB-350
 URL: https://issues.apache.org/jira/browse/OWB-350
 Project: OpenWebBeans
  Issue Type: Improvement
Affects Versions: M4
Reporter: Gurkan Erdogdu
Assignee: Gurkan Erdogdu
 Fix For: 1.0.0


 EJBs getting from @EJB or directly from jndi are non-contextuals. Spec 
 requires to support non-contextual EJBs with JSR299 interceptors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira