Re: Adding OW_ACTION_VERSION

2019-12-04 Thread Christophe Jelger
Hi Tyson, Yes it's exactly the use case you mention: the keys and values are stored externally, and yes the cache might be overwritten by concurrent action invocations. Regards, Christophe On 04.12.19, 01:32, "Tyson Norris" wrote: Hi - Just to clarify, your examples mention "cache

Re: Adding OW_ACTION_VERSION

2019-12-03 Thread Tyson Norris
Hi - Just to clarify, your examples mention "cache keys" - can you confirm these keys are stored external to the action code/container? I guess the behavior you are after is that a cache is populated the first time a particular version of the action is invoked, and the action is responsible for

Re: Adding OW_ACTION_VERSION

2019-12-03 Thread Rodric Rabbah
Thank Michele. I've submitted PRs for all the runtimes now. -r

Re: Adding OW_ACTION_VERSION

2019-12-03 Thread Michele Sciabarra
for java11 for the actionloop one. -- Michele Sciabarra mich...@sciabarra.com - Original message - From: Rodric Rabbah To: dev@openwhisk.apache.org Subject: Re: Adding OW_ACTION_VERSION Date: Tuesday, December 03, 2019 4:17 PM I went ahead and created PRs for most of the runtimes

Re: Adding OW_ACTION_VERSION

2019-12-03 Thread Rodric Rabbah
I forgot to add that the runtime PR can actually be merged ahead of the actual change upstream which I think we should accept. Will wait 48hrs for comments before having a merge fest by silent assent. -r On Tue, Dec 3, 2019 at 10:17 AM Rodric Rabbah wrote: > I went ahead and created PRs for mos

Re: Adding OW_ACTION_VERSION

2019-12-03 Thread Rodric Rabbah
I went ahead and created PRs for most of the runtimes - ones missing are Docker, Go and Swift. I noticed for Java and Ruby we have two copies of mostly the same code for action-loop and non-action-loop. Do we need two copies of the same code? These exists in Java and Ruby. I didn't spot them elsew

Re: Adding OW_ACTION_VERSION

2019-12-03 Thread Rodric Rabbah
Thanks Christophe for the contribution. The specific change is question is part of the test suite we run for all runtimes. The test checks the what values are available in the runtime context. Since there’s a new value (action version) now being checked, I see two options: Make the change as i

Adding OW_ACTION_VERSION

2019-12-03 Thread Christophe Jelger
Hello, I just joined the dev list after opened https://github.com/apache/openwhisk/pull/4761 : it adds OW_ACTION_VERSION to the execution environment. I was asked by Rodric to send this email to the list because this change will require extra changes in the runtime repos for tests (see his com