+1 to make the “code” field a string
and +1 should we choose to rename it into what it is: “id” instead of
“code”; “code” may still be used but it’s semantincs would be given by
static codes (I.e HTTP Status Codes )
If we’re interested to bring more structure we can look at some ongoing
specs eff
We just need to find the floating spec and updated with the new schema.
Also `code` is not documented as top level API or documentation, didn't
find in the swagger doc [1]
+ 1 to change and adjust downstreams (i.e. CLI, etc..)
[1]
https://github.com/apache/incubator-openwhisk/blob/master/core/co
it's unlikely, for sure, but e.g. there may be a typescript spec floating
around out there
On Thu, Apr 19, 2018 at 11:58 AM, Rodric Rabbah wrote:
> It is changing the schema for the error response, but I'm having a hard
> time thinking of a case where a client depends on the value of the "code"
I would prefer changing the schema from number to string. (And breaking any
apps that use it)
Until we have a better notion of release and versioning (including all API, db,
and message schemas), I’m not too concerned about breaking API changes at this
level (code is only useful for OW operato
It is changing the schema for the error response, but I'm having a hard
time thinking of a case where a client depends on the value of the "code"
(so that a change from int to string becomes a problem) - do you have an
example?
Renaming "code" would be more worrisome to me, but apart from the CLI,
this seems like a breaking API change. e.g. in nodejs `===` checks would
break.
On Thu, Apr 19, 2018 at 11:37 AM, Rodric Rabbah wrote:
> Should we also rename “code”?
>
> I don’t see the value in using code: 0 and changing the schema should be
> fine and better in the long run.
>
> -r
>
> > On A
Should we also rename “code”?
I don’t see the value in using code: 0 and changing the schema should be fine
and better in the long run.
-r
> On Apr 19, 2018, at 11:31 AM, Christian Bickel wrote:
>
> Hi,
>
> I'm currently working on a PR which basically moves the transactionId
> generation
Hi,
I'm currently working on a PR which basically moves the transactionId
generation from the controller to the entrypoint of the system. This is the
nginx or a frontdoor above.
One change in this PR is to change the format of the tid from a number to a
String.
This works pretty well except one
