Github user omalley commented on the pull request:
https://github.com/apache/orc/pull/29
Ok, this needed a relatively large change. To compare the schemas, I wanted
to make TypeDescription implement Comparable, but the equals and hashCode were
set up to match against the id, which wou
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/27#discussion_r65283394
--- Diff:
java/mapreduce/src/java/org.apache.orc.mapreduce/OrcInputFormat.java ---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundation (A
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/27#discussion_r65282144
--- Diff: java/mapreduce/src/test/org/apache/orc/mapreduce/TestMrUnit.java
---
@@ -0,0 +1,202 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user wagnermarkd commented on a diff in the pull request:
https://github.com/apache/orc/pull/27#discussion_r65275023
--- Diff: java/mapreduce/src/test/org/apache/orc/mapreduce/TestMrUnit.java
---
@@ -0,0 +1,202 @@
+/**
+ * Licensed to the Apache Software Foundation (
Github user wagnermarkd commented on a diff in the pull request:
https://github.com/apache/orc/pull/27#discussion_r65273378
--- Diff:
java/mapreduce/src/java/org.apache.orc.mapreduce/OrcOutputFormat.java ---
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user wagnermarkd commented on a diff in the pull request:
https://github.com/apache/orc/pull/27#discussion_r65271707
--- Diff:
java/mapreduce/src/java/org.apache.orc.mapreduce/OrcInputFormat.java ---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundatio
Github user wagnermarkd commented on a diff in the pull request:
https://github.com/apache/orc/pull/29#discussion_r65266565
--- Diff: java/mapreduce/src/java/org/apache/orc/mapred/OrcList.java ---
@@ -71,4 +71,30 @@ public void readFields(DataInput input) throws
IOException {
+1, ORC is a small enough project (both in terms of number of contributors and
code base) that CTR makes the most sense.
Alan.
> On May 28, 2016, at 23:02, Owen O'Malley wrote:
>
> All,
> While most of the Hadoop ecosystem projects including ORC work with a
> review-then-commit (RTC) process
