Re: [VOTE] ORC 1.1.2 RC 1

2016-07-06 Thread Prasanth J
+1 - verified signature and checksum - built from src - ran rat check for java - ran unit tests Thanks Prasanth > On Jul 5, 2016, at 8:22 PM, Alan Gates wrote: > > +1, checked the signatures and did a centos build. > > Alan. > >> On Jul 5, 2016, at 14:16, Owen O'Malley wrote: >> >> Ok, Pras

[jira] [Created] (ORC-81) Add support for lzo and lz4 to c++ reader

2016-07-06 Thread Owen O'Malley (JIRA)
Owen O'Malley created ORC-81: Summary: Add support for lzo and lz4 to c++ reader Key: ORC-81 URL: https://issues.apache.org/jira/browse/ORC-81 Project: Orc Issue Type: Bug Reporter: O

[GitHub] orc pull request #46: ORC-80:C++ build breaks due to warnings with gcc-4.9

2016-07-06 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/46#discussion_r69811300 --- Diff: tools/test/ToolTest.cc --- @@ -163,7 +163,7 @@ int runProgram(const std::vector& command, if (result == -1) { std::cerr << "Erro

[GitHub] orc pull request #46: ORC-80:C++ build breaks due to warnings with gcc-4.9

2016-07-06 Thread majetideepak
GitHub user majetideepak opened a pull request: https://github.com/apache/orc/pull/46 ORC-80:C++ build breaks due to warnings with gcc-4.9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/majetideepak/orc ORC-80 Alternatively you

[jira] [Created] (ORC-80) C++ build breaks due to warnings with gcc-4.9

2016-07-06 Thread Deepak Majeti (JIRA)
Deepak Majeti created ORC-80: Summary: C++ build breaks due to warnings with gcc-4.9 Key: ORC-80 URL: https://issues.apache.org/jira/browse/ORC-80 Project: Orc Issue Type: Bug Reporte

[GitHub] orc issue #40: ORC-54: Evolve schemas based on field name rather than index

2016-07-06 Thread omalley
Github user omalley commented on the issue: https://github.com/apache/orc/pull/40 This is looking good. I rebased it to the current trunk and undid some of the spacing changes. My version is here: https://github.com/omalley/orc/tree/orc-54 I also left some comments in the

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69785648 --- Diff: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java --- @@ -85,55 +142,78 @@ void buildMapping(TypeDescription fileType, // check the ea

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69785443 --- Diff: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java --- @@ -85,55 +142,78 @@ void buildMapping(TypeDescription fileType, // check the ea

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69784363 --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java --- @@ -201,6 +201,10 @@ public void nextVector(ColumnVector previous, public BitF

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69784134 --- Diff: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java --- @@ -45,16 +53,65 @@ public SchemaEvolution(TypeDescription readerSchema, boolean[] inclu

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69783819 --- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java --- @@ -933,7 +926,7 @@ void createStreams(List streamDescriptions, for (OrcProto.

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69778493 --- Diff: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java --- @@ -18,25 +18,33 @@ package org.apache.orc.impl; -import java.io.IOE

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69779322 --- Diff: java/core/src/java/org/apache/orc/OrcConf.java --- @@ -82,6 +82,12 @@ "If ORC reader encounters corrupt data, this value will be used to\n" +

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69777633 --- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java --- @@ -572,7 +572,14 @@ public RecordReader rows(Options options) throws IOException {

[GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...

2016-07-06 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/40#discussion_r69777020 --- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java --- @@ -27,21 +27,7 @@ import java.util.List; import java.util.Map; -imp