Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/123#discussion_r117397662
--- Diff: c++/include/orc/Vector.hh ---
@@ -194,6 +194,14 @@ namespace orc {
int32_t scale;
};
+ /**
+ * Compares two decimals
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/123#discussion_r117397315
--- Diff: c++/include/orc/Statistics.hh ---
@@ -392,7 +392,14 @@ namespace orc {
virtual uint32_t getNumberOfRowIndexStats(uint32_t columnId) const = 0;
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/123#discussion_r117394950
--- Diff: c++/include/orc/Vector.hh ---
@@ -194,6 +194,14 @@ namespace orc {
int32_t scale;
};
+ /**
+ * Compares two decim
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/123#discussion_r117394503
--- Diff: c++/include/orc/Statistics.hh ---
@@ -392,7 +392,14 @@ namespace orc {
virtual uint32_t getNumberOfRowIndexStats(uint32_t columnId) const
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117388912
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Sergey Shelukhin created ORC-197:
Summary: ensureOrcFooter bug
Key: ORC-197
URL: https://issues.apache.org/jira/browse/ORC-197
Project: ORC
Issue Type: Bug
Reporter: Sergey Sheluk
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117381049
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
+
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117380455
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Deepak Majeti created ORC-196:
-
Summary: [C++] Rename ParseError to OrcError and use it in both
read and write paths
Key: ORC-196
URL: https://issues.apache.org/jira/browse/ORC-196
Project: ORC
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117380313
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
+
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117379977
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117379895
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
+
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117379212
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117378369
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
+
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117377956
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/123
@wgtmac I will take a look at it in some time tonight. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117377410
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user wgtmac commented on the issue:
https://github.com/apache/orc/pull/123
@majetideepak how does this PR look to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117363862
--- Diff: c++/src/Compression.cc ---
@@ -636,6 +884,33 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ std::unique_ptr
+ creat
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117363781
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
+
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117355319
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117354764
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117355243
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117354986
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117357368
--- Diff: c++/src/Compression.cc ---
@@ -636,6 +884,33 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ std::unique_ptr
+
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117355282
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117360126
--- Diff: c++/src/Compression.cc ---
@@ -636,6 +884,33 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ std::unique_ptr
+
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117355066
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream {
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/122
@omalley can you please take a look at this? Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user xndai opened a pull request:
https://github.com/apache/orc/pull/126
ORC-191 Implement RLE v1 encoder
Implement integer, byte and boolean RLE encoder, and add corresponding
UTs. Only v1 is implemented at this point.
Change-Id: Ia03b0d8bf98a843e45da8a5d349efeff
Eugene Koifman created ORC-195:
--
Summary: FileFormatException should include file name in the
message
Key: ORC-195
URL: https://issues.apache.org/jira/browse/ORC-195
Project: ORC
Issue Type: Bu
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user prasanthj commented on the issue:
https://github.com/apache/orc/pull/124
lgtm, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
33 matches
Mail list logo
