[GitHub] orc issue #233: ORC-322: [C++] Fix writing & reading timestamp

Github user wgtmac commented on the issue: https://github.com/apache/orc/pull/233 Thanks @majetideepak ! ---

[GitHub] orc pull request #233: ORC-322: [C++] Fix writing & reading timestamp

Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/233 ---

[GitHub] orc issue #233: ORC-322: [C++] Fix writing & reading timestamp

Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/233 You are right about the last commit. It is redundant! I will remove that commit and merge this. Thanks! ---

[GitHub] orc pull request #238: ORC-329: [C++] Fix error: zero as null pointer consta...

Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/238 ---

[GitHub] orc issue #233: ORC-322: [C++] Fix writing & reading timestamp

Github user wgtmac commented on the issue: https://github.com/apache/orc/pull/233 @majetideepak Done! I didn't add setWriterTimezone method because we don't expect users to change the writer timezone. Please also take a look at this minor fix: https://github.com/apache/orc/pull/23

[GitHub] orc issue #233: ORC-322: [C++] Fix writing & reading timestamp

Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/233 Can we extend this by adding a `WriterOption` to provide a timezone name (default to "GMT")? ---