dongjoon-hyun commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r578118181
##
File path: c++/src/ColumnReader.cc
##
@@ -1553,6 +1558,8 @@ namespace orc {
ColumnReader::seekToRowGroup(positions);
valueStream->seek(positi
dongjoon-hyun commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r578117820
##
File path: c++/src/Reader.hh
##
@@ -19,13 +19,14 @@
#ifndef ORC_READER_IMPL_HH
#define ORC_READER_IMPL_HH
+#include "orc/Exceptions.hh"
#include "
wgtmac commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r578095884
##
File path: c++/src/Reader.hh
##
@@ -19,13 +19,14 @@
#ifndef ORC_READER_IMPL_HH
#define ORC_READER_IMPL_HH
+#include "orc/Exceptions.hh"
#include "orc/Int
omalley commented on pull request #643:
URL: https://github.com/apache/orc/pull/643#issuecomment-780929750
It looks like it is passing now.
https://www.travis-ci.com/github/apache/orc/builds/217427153
This is an automated m
pavibhai commented on pull request #635:
URL: https://github.com/apache/orc/pull/635#issuecomment-780918832
> With the update to master, I'm seeing a findbugs failure:
>
> Dead store to readPercentage in
org.apache.orc.TestRowFilteringIOSkip.filterAlternateBatches()
[org.apache.orc.
omalley commented on pull request #635:
URL: https://github.com/apache/orc/pull/635#issuecomment-780899790
With the update to master, I'm seeing a findbugs failure:
Dead store to readPercentage in
org.apache.orc.TestRowFilteringIOSkip.filterAlternateBatches()
[org.apache.orc.TestRow
dongjoon-hyun commented on pull request #643:
URL: https://github.com/apache/orc/pull/643#issuecomment-780896217
BTW, do you know why Travis CI is failing?
This is an automated message from the Apache Git Service.
To respond
omalley merged pull request #643:
URL: https://github.com/apache/orc/pull/643
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
pgaref commented on pull request #643:
URL: https://github.com/apache/orc/pull/643#issuecomment-780871253
Changes LGTM - +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
omalley opened a new pull request #643:
URL: https://github.com/apache/orc/pull/643
This refactors the benchmark pom so that it uses the orc pom as the parent.
That allows us to remove some duplication and means that the analyze profile
becomes defined with benchmarks.
With th
omalley merged pull request #642:
URL: https://github.com/apache/orc/pull/642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dongjoon-hyun commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r577898333
##
File path: c++/src/ColumnReader.cc
##
@@ -1553,6 +1558,8 @@ namespace orc {
ColumnReader::seekToRowGroup(positions);
valueStream->seek(positi
dongjoon-hyun commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r577896311
##
File path: c++/src/Reader.hh
##
@@ -19,13 +19,14 @@
#ifndef ORC_READER_IMPL_HH
#define ORC_READER_IMPL_HH
+#include "orc/Exceptions.hh"
#include "
dongjoon-hyun commented on pull request #476:
URL: https://github.com/apache/orc/pull/476#issuecomment-780803638
Thank you for pinging me, @wgtmac .
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on a change in pull request #564:
URL: https://github.com/apache/orc/pull/564#discussion_r577892974
##
File path: java/core/src/java/org/apache/orc/Reader.java
##
@@ -390,8 +399,15 @@ public SearchArgument getSearchArgument() {
return preFilterCol
omalley commented on pull request #642:
URL: https://github.com/apache/orc/pull/642#issuecomment-780792549
By turning on the analyze profile in the CI build, now we get find bugs
again in CI.
Java 11 causes a new set of findbugs false alarms, so those need to be
suppressed.
I
wgtmac commented on pull request #476:
URL: https://github.com/apache/orc/pull/476#issuecomment-780568496
Thanks @pgaref for the comments! I will fix them and then let you know.
This is an automated message from the Apache Gi
pgaref commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r577557420
##
File path: c++/test/TestPredicatePushdown.cc
##
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
pgaref commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r577532087
##
File path: c++/src/Reader.cc
##
@@ -68,6 +68,12 @@ namespace orc {
return columnPath.substr(0, columnPath.length() - 1);
}
+ WriterVersion getWri
Panagiotis Garefalakis created ORC-751:
--
Summary: [C++] Implement Predicate Pushdown for C++ Reader
Key: ORC-751
URL: https://issues.apache.org/jira/browse/ORC-751
Project: ORC
Issue Typ
pgaref commented on pull request #499:
URL: https://github.com/apache/orc/pull/499#issuecomment-780472033
Was reviewing https://github.com/apache/orc/pull/476 and bump into this --
shall we revive this? @luksan47 @wgtmac
T
pgaref commented on pull request #642:
URL: https://github.com/apache/orc/pull/642#issuecomment-780451363
> Thank you, @omalley . Is this blocked by
[ORC-750](https://issues.apache.org/jira/browse/ORC-750) ?
These look like findbugs issues -- the interesting fact is that they only
s
22 matches
Mail list logo
