[GitHub] [orc] dongjoon-hyun commented on pull request #664: ORC-769: Support ZSTD in ORC data benchmark

dongjoon-hyun commented on pull request #664: URL: https://github.com/apache/orc/pull/664#issuecomment-804635771 I simplified the PR description by focusing on `sales` synthetic data and skipping dowloading the other web data (`taxi`/`github`). -- This is an automated message from the Ap

[GitHub] [orc] dongjoon-hyun commented on pull request #664: ORC-769: Support ZSTD in ORC data benchmark

dongjoon-hyun commented on pull request #664: URL: https://github.com/apache/orc/pull/664#issuecomment-804608333 Could you review this, @omalley , @pgaref , @wgtmac ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [orc] dongjoon-hyun commented on pull request #661: ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC

dongjoon-hyun commented on pull request #661: URL: https://github.com/apache/orc/pull/661#issuecomment-804602374 Thank you for adding the test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [orc] dongjoon-hyun commented on pull request #631: ORC-738: Add date type conversion support in `Java Tools`

dongjoon-hyun commented on pull request #631: URL: https://github.com/apache/orc/pull/631#issuecomment-804524982 Hi, @darkamgine . Do you have Apache JIRA id? We want to assign ORC-738 to you . -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #664: ORC-769: Support ZSTD in benchmark ORC data generation

dongjoon-hyun commented on a change in pull request #664: URL: https://github.com/apache/orc/pull/664#discussion_r599168290 ## File path: java/bench/pom.xml ## @@ -81,13 +81,7 @@ io.airlift aircompressor -0.10 - - -

[GitHub] [orc] dongjoon-hyun opened a new pull request #664: ORC-769: Support ZSTD in benchmark ORC data generation

dongjoon-hyun opened a new pull request #664: URL: https://github.com/apache/orc/pull/664 ### What changes were proposed in this pull request? This PR aims to support ZSTD compression at benchmark ORC data generation. ### Why are the changes needed? Apache ORC 1.6+ suppo

[jira] [Created] (ORC-769) Support ZSTD in benchmark data generation

Dongjoon Hyun created ORC-769: - Summary: Support ZSTD in benchmark data generation Key: ORC-769 URL: https://issues.apache.org/jira/browse/ORC-769 Project: ORC Issue Type: Improvement C

[GitHub] [orc] dongjoon-hyun merged pull request #663: ORC-768: Update commons-csv to 1.8

dongjoon-hyun merged pull request #663: URL: https://github.com/apache/orc/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [orc] omalley commented on pull request #662: MINOR: Fix typo in make-release.md

omalley commented on pull request #662: URL: https://github.com/apache/orc/pull/662#issuecomment-804439515 Thanks, @williamhyun. The danger of git supporting aliases is that one of mine slipped in to this page. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [orc] pgaref merged pull request #662: MINOR: Fix typo in make-release.md

pgaref merged pull request #662: URL: https://github.com/apache/orc/pull/662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contac

[GitHub] [orc] williamhyun opened a new pull request #663: ORC-768: Update commons-csv to 1.8

williamhyun opened a new pull request #663: URL: https://github.com/apache/orc/pull/663 ### What changes were proposed in this pull request? This PR aims to update commons-csv to version 1.8. ### Why are the changes needed? This will bring the latest bug fixes and improv

[jira] [Created] (ORC-768) Update commons-csv to 1.8

William Hyun created ORC-768: Summary: Update commons-csv to 1.8 Key: ORC-768 URL: https://issues.apache.org/jira/browse/ORC-768 Project: ORC Issue Type: Improvement Components: build

[GitHub] [orc] williamhyun opened a new pull request #662: MINOR: Fix typo in make-release.md

williamhyun opened a new pull request #662: URL: https://github.com/apache/orc/pull/662 ### What changes were proposed in this pull request? This PR aims to fix a typo in make-release.md. ### Why are the changes needed? `git co` is an incorrect command because co is from

[GitHub] [orc] pavibhai commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pavibhai commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598955808 ## File path: java/core/src/java/org/apache/orc/impl/InStream.java ## @@ -558,9 +558,14 @@ public void changeIv(Consumer modifier) { public void seek(Posi

[GitHub] [orc] dongjoon-hyun merged pull request #660: ORC-728: Support head command in Java Tools

dongjoon-hyun merged pull request #660: URL: https://github.com/apache/orc/pull/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [orc] omalley commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

omalley commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598921532 ## File path: java/core/src/java/org/apache/orc/impl/InStream.java ## @@ -558,9 +558,14 @@ public void changeIv(Consumer modifier) { public void seek(Posit

[GitHub] [orc] pavibhai commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pavibhai commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598817629 ## File path: java/core/src/java/org/apache/orc/impl/InStream.java ## @@ -551,15 +556,20 @@ public void changeIv(Consumer modifier) { @Override pub

[GitHub] [orc] pavibhai commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pavibhai commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598817629 ## File path: java/core/src/java/org/apache/orc/impl/InStream.java ## @@ -551,15 +556,20 @@ public void changeIv(Consumer modifier) { @Override pub

[GitHub] [orc] pavibhai commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pavibhai commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598817629 ## File path: java/core/src/java/org/apache/orc/impl/InStream.java ## @@ -551,15 +556,20 @@ public void changeIv(Consumer modifier) { @Override pub

[GitHub] [orc] pavibhai commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pavibhai commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598805851 ## File path: java/core/src/java/org/apache/orc/impl/InStream.java ## @@ -471,6 +472,7 @@ private int readHeaderByte() { } private void readHeader(

[GitHub] [orc] pavibhai commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pavibhai commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598805052 ## File path: java/core/src/java/org/apache/orc/impl/InStream.java ## @@ -397,13 +397,14 @@ public String toString() { } } - private static class Co

[GitHub] [orc] pavibhai commented on a change in pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pavibhai commented on a change in pull request #652: URL: https://github.com/apache/orc/pull/652#discussion_r598802721 ## File path: java/core/src/test/org/apache/orc/impl/TestInStream.java ## @@ -19,6 +19,9 @@ package org.apache.orc.impl; Review comment: Added the tes

[GitHub] [orc] pgaref commented on a change in pull request #651: ORC-757: HashTable dictionary

pgaref commented on a change in pull request #651: URL: https://github.com/apache/orc/pull/651#discussion_r598714046 ## File path: java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [orc] pgaref commented on a change in pull request #651: ORC-757: HashTable dictionary

pgaref commented on a change in pull request #651: URL: https://github.com/apache/orc/pull/651#discussion_r598636479 ## File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [orc] pgaref commented on pull request #652: ORC-758: Avoid seeking and decompressing of compressed stream

pgaref commented on pull request #652: URL: https://github.com/apache/orc/pull/652#issuecomment-803987057 Hey @pavibhai can you please check the remaining comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the