coderex2522 commented on pull request #683:
URL: https://github.com/apache/orc/pull/683#issuecomment-818866913
Hey @wgtmac, the UT of this patch don't support on windows system. There are
several problems here
1) Windows don't support acquiring the structure timezone.
2) The
coderex2522 commented on pull request #675:
URL: https://github.com/apache/orc/pull/675#issuecomment-818847190
> Thanks for the contribution @coderex2522! Basically this patch does two
things: 1) support setting writer/reader timezone to remove the hack which
hardcodes timezone to GMT. 2)
coderex2522 opened a new pull request #683:
URL: https://github.com/apache/orc/pull/683
### How was this patch tested?
this patch is tested by the ut of writeTimestampWithTimezone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Looks good Owen.
One minor comment inline below.
> On Apr 12, 2021, at 4:49 PM, Owen O'Malley wrote:
>
> All,
> Please send me any feedback. Thanks!
>
> ## Description:
> The mission of ORC is the creation and maintenance of software related to
> the
> smallest, fastest columnar storage for
ZhangXin created ORC-784:
Summary: [C++] Read/Write timestamp column with the specified
timezone option
Key: ORC-784
URL: https://issues.apache.org/jira/browse/ORC-784
Project: ORC
Issue Type: New
It looks good to me. Thank you, Owen.
On Mon, Apr 12, 2021 at 4:49 PM Owen O'Malley
wrote:
> All,
>Please send me any feedback. Thanks!
>
> ## Description:
> The mission of ORC is the creation and maintenance of software related to
> the
> smallest, fastest columnar storage for Hadoop
