David Mollitor created ORC-838:
--
Summary: Implement Improvements to ByteBufferAllocatorPool
Key: ORC-838
URL: https://issues.apache.org/jira/browse/ORC-838
Project: ORC
Issue Type: Improvement
belugabehr commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665807525
##
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##
@@ -44,9 +44,22 @@
/**
* Given the position index, return the original strin
belugabehr commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665806375
##
File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java
##
@@ -42,4 +44,29 @@ public static void getTextInternal(Text result, int
position
belugabehr commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665805203
##
File path: java/core/src/java/org/apache/orc/impl/DynamicByteArray.java
##
@@ -222,10 +222,10 @@ public void setText(Text result, int offset, int length)
belugabehr commented on pull request #736:
URL: https://github.com/apache/orc/pull/736#issuecomment-876025178
> Sorry for adding last-minute comments after approval.
No worries at all. Thanks for being engaged and helping me get these PRs
reviewed. You are very generous with your ti
belugabehr commented on a change in pull request #739:
URL: https://github.com/apache/orc/pull/739#discussion_r665788810
##
File path: java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java
##
@@ -504,38 +504,33 @@ static void readDiskRanges(FSDataInputStream file,
kbendick commented on a change in pull request #739:
URL: https://github.com/apache/orc/pull/739#discussion_r665751393
##
File path: java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java
##
@@ -504,38 +504,33 @@ static void readDiskRanges(FSDataInputStream file,
pr
dongjoon-hyun commented on pull request #736:
URL: https://github.com/apache/orc/pull/736#issuecomment-875954235
Sorry for adding last-minute comments after approval. Please consider the
above comments.
--
This is an automated message from the Apache Git Service.
To respond to the messag
dongjoon-hyun commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665721041
##
File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java
##
@@ -42,4 +44,29 @@ public static void getTextInternal(Text result, int
posit
dongjoon-hyun commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665720389
##
File path: java/core/src/java/org/apache/orc/impl/DynamicByteArray.java
##
@@ -222,10 +222,10 @@ public void setText(Text result, int offset, int lengt
dongjoon-hyun commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665715334
##
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##
@@ -44,9 +44,22 @@
/**
* Given the position index, return the original st
dongjoon-hyun merged pull request #738:
URL: https://github.com/apache/orc/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
dongjoon-hyun commented on pull request #738:
URL: https://github.com/apache/orc/pull/738#issuecomment-875940248
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
belugabehr opened a new pull request #740:
URL: https://github.com/apache/orc/pull/740
### What changes were proposed in this pull request?
When converting from Double to String, use the Double class methods
directly. Lower overhead of encoding by using ASCII.
### Why are the
belugabehr opened a new pull request #739:
URL: https://github.com/apache/orc/pull/739
TODO: CREATE JIRA
### What changes were proposed in this pull request?
Simplify ByteBufferAllocatorPool Key class. Cache hash value for Key as it's
computed more than once: putBuffer to insert i
David Mollitor created ORC-837:
--
Summary: Reuse HiveDecimalWritable in ConvertTreeReaderFactory
Key: ORC-837
URL: https://issues.apache.org/jira/browse/ORC-837
Project: ORC
Issue Type: Improveme
David Mollitor created ORC-836:
--
Summary: StringGroupFromDoubleTreeReader Use Long.toString
Key: ORC-836
URL: https://issues.apache.org/jira/browse/ORC-836
Project: ORC
Issue Type: Improvement
David Mollitor created ORC-835:
--
Summary: Cache TRUE/FALSE Bytes in StringGroupFromBooleanTreeReader
Key: ORC-835
URL: https://issues.apache.org/jira/browse/ORC-835
Project: ORC
Issue Type: Impr
David Mollitor created ORC-834:
--
Summary: Do Not Convert to String in DecimalFromTimestampTreeReader
Key: ORC-834
URL: https://issues.apache.org/jira/browse/ORC-834
Project: ORC
Issue Type: Impr
belugabehr opened a new pull request #738:
URL: https://github.com/apache/orc/pull/738
### What changes were proposed in this pull request?
The number of iterations of the loops in RunLengthIntegerReaderV2 nextVector
look at two distinct, but known, values. Instead of check each valu
David Mollitor created ORC-833:
--
Summary: RunLengthIntegerReaderV2 Calculate Batch Size One
Key: ORC-833
URL: https://issues.apache.org/jira/browse/ORC-833
Project: ORC
Issue Type: Improvement
pgaref merged pull request #734:
URL: https://github.com/apache/orc/pull/734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.a
pgaref commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665440165
##
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##
@@ -47,6 +47,15 @@
*/
void getText(Text result, int position);
+ /**
+ * Give
belugabehr commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665417540
##
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##
@@ -47,6 +47,15 @@
*/
Review comment:
Donr.
--
This is an automated
belugabehr commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665397854
##
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##
@@ -47,6 +47,15 @@
*/
void getText(Text result, int position);
+ /**
+ *
belugabehr commented on pull request #734:
URL: https://github.com/apache/orc/pull/734#issuecomment-875591895
> Hey @belugabehr changes LGTM -- just wondering if we can/should
incorporate the Perf tests you did when discovered this?
@pgaref Hey, thanks for taking a look.
Nothi
David Justen created ORC-832:
Summary: [C++] Support intermediate file footers
Key: ORC-832
URL: https://issues.apache.org/jira/browse/ORC-832
Project: ORC
Issue Type: New Feature
Comp
pgaref commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665341392
##
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##
@@ -47,6 +47,15 @@
*/
void getText(Text result, int position);
+ /**
+ * Give
pgaref commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665340919
##
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##
@@ -47,6 +47,15 @@
*/
Review comment:
Can we please mention here that this me
pgaref commented on a change in pull request #734:
URL: https://github.com/apache/orc/pull/734#discussion_r665224823
##
File path: java/core/src/java/org/apache/orc/impl/SerializationUtils.java
##
@@ -287,27 +293,24 @@ public long zigzagDecode(long val) {
* @param p - perce
30 matches
Mail list logo
