belugabehr commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r671935567
##
File path: java/core/src/java/org/apache/orc/impl/DynamicByteArray.java
##
@@ -294,6 +295,16 @@ public void setByteBuffer(ByteBuffer result, int offset,
belugabehr opened a new pull request #754:
URL: https://github.com/apache/orc/pull/754
### What changes were proposed in this pull request?
Allow `DyanmicByteArray` and `Dictionary` to return a ByteBuffer of its
content.
### Why are the changes needed?
Performance.
David Mollitor created ORC-852:
--
Summary: Allow DynamicByteArray to Return a ByteBuffer
Key: ORC-852
URL: https://issues.apache.org/jira/browse/ORC-852
Project: ORC
Issue Type: Improvement
williamhyun commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882150965
+1 LGTM
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
asfgit closed pull request #737:
URL: https://github.com/apache/orc/pull/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.a
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882145169
Merged to main. Thank you, @williamhyun and all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun merged pull request #753:
URL: https://github.com/apache/orc/pull/753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
belugabehr commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144992
Hey, ya, I'm quite familiar. I was just looking about to look that up
regarding scope. I didn't not consider scope inheritance here. Again, sorry for
the inconvenience.
--
This
dongjoon-hyun edited a comment on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144772
BTW, no worries, @belugabehr . This is not released yet. It's lucky to find
at this earlier stage.
--
This is an automated message from the Apache Git Service.
To respo
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144772
BTW, no worries, @belugabehr . This is not released yet. It's lucky to find
this earlier stage.
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144488
@belugabehr . Do you know Maven POM inheritance? Here is the reference for
you.
- https://maven.apache.org/pom.html#inheritance
--
This is an automated message from the Apa
belugabehr commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882141827
Hmm. I see. My apologies and thanks for the catch. However, maybe I'm
missing something obvious, but this PR simply adds the "compile" scope to
something that previously had no sc
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140722
@belugabehr . Please check the parent pom here.
- https://github.com/apache/orc/blob/main/java/pom.xml#L525
- https://github.com/apache/orc/blob/main/java/pom.xml#L754
--
dongjoon-hyun edited a comment on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140301
@belugabehr . Your PR changed `compile` dependency to `provided` dependency.
That's the regression which @williamhyun found. The ORC tools uber jar should
have all requir
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140356
+1, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140301
@belugabehr . Your PR changes `compile` dependency to `provided` dependency.
That's the regression which @williamhyun found. The ORC tools uber jar should
have all required jars
belugabehr commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882139262
I'm not sure I understand the change.
> compile This is the default scope, used if none is specified.
I do not expect this patch to have any affect on the build. Can yo
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882138428
Thank you so much, @williamhyun and @pgaref !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dongjoon-hyun commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-882138264
Oh. My bad. Thank you, @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
williamhyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882134205
CC: @belugabehr @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
williamhyun opened a new pull request #753:
URL: https://github.com/apache/orc/pull/753
### What changes were proposed in this pull request?
### Why are the changes needed?
### How was this patch tested?
--
This is an automated message from th
William Hyun created ORC-851:
Summary: Fix CNFE in ORC tools uber jar to include required
classes.
Key: ORC-851
URL: https://issues.apache.org/jira/browse/ORC-851
Project: ORC
Issue Type: Bug
williamhyun commented on a change in pull request #708:
URL: https://github.com/apache/orc/pull/708#discussion_r671914990
##
File path: java/tools/pom.xml
##
@@ -82,7 +80,6 @@
com.google.guava
guava
- compile
Review comment:
This one is also req
williamhyun commented on a change in pull request #708:
URL: https://github.com/apache/orc/pull/708#discussion_r671914934
##
File path: java/tools/pom.xml
##
@@ -58,13 +58,11 @@
org.apache.hadoop
hadoop-common
${tools.hadoop.version}
- compile
Review
pgaref merged pull request #744:
URL: https://github.com/apache/orc/pull/744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.a
25 matches
Mail list logo
