[GitHub] [orc] dongjoon-hyun commented on pull request #790: ORC-887: Remove ORC Twitter link from news page

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #790: URL: https://github.com/apache/orc/pull/790#issuecomment-889633983 cc @omalley , @pgaref , @wgtmac , @williamhyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [orc] dongjoon-hyun opened a new pull request #790: ORC-887: Remove ORC Twitter link from news page

2021-07-29 Thread GitBox
dongjoon-hyun opened a new pull request #790: URL: https://github.com/apache/orc/pull/790 ### What changes were proposed in this pull request? This PR aims to remove ORC Twitter link from `news` page because it's not used for `news`. The last tweet is 2018. ![Screen Shot 2021-

[jira] [Created] (ORC-887) Remove ORC Twitter link from `news` page

2021-07-29 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-887: - Summary: Remove ORC Twitter link from `news` page Key: ORC-887 URL: https://issues.apache.org/jira/browse/ORC-887 Project: ORC Issue Type: Task Component

[GitHub] [orc] dongjoon-hyun merged pull request #789: ORC-885: Update bench README.md and allow user env shell

2021-07-29 Thread GitBox
dongjoon-hyun merged pull request #789: URL: https://github.com/apache/orc/pull/789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [orc] dongjoon-hyun commented on pull request #789: ORC-885: Update bench README.md and allow user env shell

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #789: URL: https://github.com/apache/orc/pull/789#issuecomment-889541764 Merged to main/1.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [orc] dongjoon-hyun commented on pull request #789: ORC-885: Update bench README.md and allow user env shell

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #789: URL: https://github.com/apache/orc/pull/789#issuecomment-889525290 Thank you so much, @omalley ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (ORC-886) Add an integration test for ORC Java tools

2021-07-29 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-886: - Summary: Add an integration test for ORC Java tools Key: ORC-886 URL: https://issues.apache.org/jira/browse/ORC-886 Project: ORC Issue Type: Test Compone

[GitHub] [orc] dongjoon-hyun commented on pull request #789: ORC-885: Update bench README.md and allow user env shell

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #789: URL: https://github.com/apache/orc/pull/789#issuecomment-889493246 Could you review this, @pgaref and @williamhyun ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #773: ORC-867: Upgrade hive-storage-api to 2.8.0

2021-07-29 Thread GitBox
dongjoon-hyun edited a comment on pull request #773: URL: https://github.com/apache/orc/pull/773#issuecomment-889479998 Since https://github.com/apache/hive/pull/2543 is merged, we will retry when `hive-storage-api` 2.8.1 is released. -- This is an automated message from the Apache Git S

[GitHub] [orc] dongjoon-hyun commented on pull request #773: ORC-867: Upgrade hive-storage-api to 2.8.0

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #773: URL: https://github.com/apache/orc/pull/773#issuecomment-889479998 For this one, we will retry when `hive-storage-api` 2.8.1 is ready. - -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [orc] dongjoon-hyun commented on pull request #788: ORC-882: Remove hamcrest-core test dependency

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #788: URL: https://github.com/apache/orc/pull/788#issuecomment-889479088 cc @pgaref and @williamhyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [orc] dongjoon-hyun opened a new pull request #789: ORC-885: Update bench README.md and allow user env shell

2021-07-29 Thread GitBox
dongjoon-hyun opened a new pull request #789: URL: https://github.com/apache/orc/pull/789 ### What changes were proposed in this pull request? This PR aims to update `READM.md` in bench submodule and allow user environment shell in `fetch-data.sh`. ### Why are the changes need

[jira] [Created] (ORC-885) Update bench README.md and allow user env shell

2021-07-29 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-885: - Summary: Update bench README.md and allow user env shell Key: ORC-885 URL: https://issues.apache.org/jira/browse/ORC-885 Project: ORC Issue Type: Bug Com

[GitHub] [orc] dongjoon-hyun commented on pull request #770: Bump jettison from 1.1 to 1.4.1 in /java

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #770: URL: https://github.com/apache/orc/pull/770#issuecomment-889433389 I created ORC-884 to keep in the loop. For `Dependabot` PRs, I set the committer as the assignee. :) -- This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (ORC-884) Bump jettison from 1.1 to 1.4.1

2021-07-29 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-884: - Summary: Bump jettison from 1.1 to 1.4.1 Key: ORC-884 URL: https://issues.apache.org/jira/browse/ORC-884 Project: ORC Issue Type: Sub-task Components: Ja

[jira] [Created] (ORC-883) Dependency Audit and QA

2021-07-29 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-883: - Summary: Dependency Audit and QA Key: ORC-883 URL: https://issues.apache.org/jira/browse/ORC-883 Project: ORC Issue Type: Task Components: Java Affec

[GitHub] [orc] dongjoon-hyun opened a new pull request #788: ORC-882: Remove hamcrest-core test dependency

2021-07-29 Thread GitBox
dongjoon-hyun opened a new pull request #788: URL: https://github.com/apache/orc/pull/788 ### What changes were proposed in this pull request? This PR aims to remove `hamcrest-core` test dependency. ### Why are the changes needed? This was added at ORC-60 and is not used

[GitHub] [orc] dongjoon-hyun commented on pull request #778: Bump hamcrest-core from 1.3 to 2.2 in /java

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #778: URL: https://github.com/apache/orc/pull/778#issuecomment-889429582 For this one, I'll create a PR to remove this dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Created] (ORC-882) Remove hamcrest-core test dependency

2021-07-29 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-882: - Summary: Remove hamcrest-core test dependency Key: ORC-882 URL: https://issues.apache.org/jira/browse/ORC-882 Project: ORC Issue Type: Test Components: J

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #787: ORC-880: Reduce Visibility of DictionaryUtils

2021-07-29 Thread GitBox
dongjoon-hyun edited a comment on pull request #787: URL: https://github.com/apache/orc/pull/787#issuecomment-889403816 We cannot hide all of them because it's an unnecessarily breaking change. At 1.7.0, we already recovered many things to help the downstreams' migration. Although they are

[GitHub] [orc] dongjoon-hyun commented on pull request #787: ORC-880: Reduce Visibility of DictionaryUtils

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #787: URL: https://github.com/apache/orc/pull/787#issuecomment-889403816 We cannot hide all of them because it's an unnecessarily breaking change. At 1.7.0, we already recovered many things to help the downstreams' migration. Although they are design

[GitHub] [orc] dongjoon-hyun merged pull request #741: ORC-835: Cache TRUE/FALSE Bytes in StringGroupFromBooleanTreeReader

2021-07-29 Thread GitBox
dongjoon-hyun merged pull request #741: URL: https://github.com/apache/orc/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [orc] belugabehr commented on pull request #787: ORC-880: Reduce Visibility of DictionaryUtils

2021-07-29 Thread GitBox
belugabehr commented on pull request #787: URL: https://github.com/apache/orc/pull/787#issuecomment-889396000 @dongjoon-hyun Would you rather I abandon this effort altogether or apply this same change to all the `util` classes? -- This is an automated message from the Apache Git Service.

[GitHub] [orc] dongjoon-hyun merged pull request #786: ORC-881: Bump slf4j.version from 1.7.30 to 1.7.32

2021-07-29 Thread GitBox
dongjoon-hyun merged pull request #786: URL: https://github.com/apache/orc/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[jira] [Created] (ORC-881) Bump slf4j.version from 1.7.30 to 1.7.32

2021-07-29 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-881: - Summary: Bump slf4j.version from 1.7.30 to 1.7.32 Key: ORC-881 URL: https://issues.apache.org/jira/browse/ORC-881 Project: ORC Issue Type: Improvement Co

[GitHub] [orc] dongjoon-hyun commented on pull request #781: Bump objenesis from 3.1 to 3.2 in /java

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #781: URL: https://github.com/apache/orc/pull/781#issuecomment-889349655 It would be great if we can remove this if Apache ORC are not using it technically. Otherwise, Dependabot will keep informing us all updates. -- This is an automated message f

[GitHub] [orc] dongjoon-hyun commented on pull request #781: Bump objenesis from 3.1 to 3.2 in /java

2021-07-29 Thread GitBox
dongjoon-hyun commented on pull request #781: URL: https://github.com/apache/orc/pull/781#issuecomment-889349161 Hi, @williamhyun . This was added when we adds Java 17 tests. Although they are compile-dependency of `mockito`, but it seems that we are not using them. Could you double-check

[GitHub] [orc] belugabehr opened a new pull request #787: ORC-880: Reduce Visibility of DictionaryUtils

2021-07-29 Thread GitBox
belugabehr opened a new pull request #787: URL: https://github.com/apache/orc/pull/787 ### What changes were proposed in this pull request? Reduce visibility of class `DictionaryUtils`. ### Why are the changes needed? Prevent a situation where an external user has a dependency o

[jira] [Created] (ORC-880) Reduce Visibility of DictionaryUtils

2021-07-29 Thread David Mollitor (Jira)
David Mollitor created ORC-880: -- Summary: Reduce Visibility of DictionaryUtils Key: ORC-880 URL: https://issues.apache.org/jira/browse/ORC-880 Project: ORC Issue Type: Improvement Re

[jira] [Created] (ORC-879) Flaky Test for TestJsonReader

2021-07-29 Thread David Mollitor (Jira)
David Mollitor created ORC-879: -- Summary: Flaky Test for TestJsonReader Key: ORC-879 URL: https://issues.apache.org/jira/browse/ORC-879 Project: ORC Issue Type: Improvement Reporter:

[GitHub] [orc] belugabehr closed pull request #735: ORC-830: Do Not Copy String When Adding to StringHashTableDictionary

2021-07-29 Thread GitBox
belugabehr closed pull request #735: URL: https://github.com/apache/orc/pull/735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@o

[GitHub] [orc] belugabehr commented on pull request #741: ORC-835: Cache TRUE/FALSE Bytes in StringGroupFromBooleanTreeReader

2021-07-29 Thread GitBox
belugabehr commented on pull request #741: URL: https://github.com/apache/orc/pull/741#issuecomment-889182765 @kbendick OK to merge? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [orc] belugabehr commented on pull request #756: ORC-854: Optimize ReadFully for Full Reads

2021-07-29 Thread GitBox
belugabehr commented on pull request #756: URL: https://github.com/apache/orc/pull/756#issuecomment-889175828 @kbendick @pgaref Good to merge? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [orc] belugabehr commented on pull request #735: ORC-830: Do Not Copy String When Adding to StringHashTableDictionary

2021-07-29 Thread GitBox
belugabehr commented on pull request #735: URL: https://github.com/apache/orc/pull/735#issuecomment-889143219 @pgaref @kbendick @autumnust This is related to #748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [orc] pgaref closed pull request #748: ORC-842: Remove newKey from StringHashTableDictionary

2021-07-29 Thread GitBox
pgaref closed pull request #748: URL: https://github.com/apache/orc/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.a

[GitHub] [orc] pgaref commented on pull request #748: ORC-842: Remove newKey from StringHashTableDictionary

2021-07-29 Thread GitBox
pgaref commented on pull request #748: URL: https://github.com/apache/orc/pull/748#issuecomment-888982891 Thank you all! This is now merged to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [orc] dependabot[bot] opened a new pull request #786: Bump slf4j.version from 1.7.30 to 1.7.32 in /java

2021-07-29 Thread GitBox
dependabot[bot] opened a new pull request #786: URL: https://github.com/apache/orc/pull/786 Bumps `slf4j.version` from 1.7.30 to 1.7.32. Updates `slf4j-api` from 1.7.30 to 1.7.32 Commits See full diff in https://github.com/qos-ch/slf4j/commits";>compare view