[GitHub] [orc] dongjoon-hyun merged pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

2021-08-02 Thread GitBox
dongjoon-hyun merged pull request #807: URL: https://github.com/apache/orc/pull/807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [orc] dongjoon-hyun commented on pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #807: URL: https://github.com/apache/orc/pull/807#issuecomment-891551042 Thank you, @williamhyun ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [orc] dongjoon-hyun commented on pull request #808: ORC-902: Fix hadoop-common dependency scope in orc-example

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #808: URL: https://github.com/apache/orc/pull/808#issuecomment-891550231 Merged to main/1.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [orc] dongjoon-hyun merged pull request #808: ORC-902: Fix hadoop-common dependency scope in orc-example

2021-08-02 Thread GitBox
dongjoon-hyun merged pull request #808: URL: https://github.com/apache/orc/pull/808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [orc] dongjoon-hyun commented on pull request #808: ORC-902: Fix hadoop-common dependency scope in orc-example

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #808: URL: https://github.com/apache/orc/pull/808#issuecomment-891547287 Now, every example runs? > None of the 4 examples can run, because they all need new Configuration(). -- This is an automated message from the Apache Git Service. To

[GitHub] [orc] guiyanakuang commented on pull request #808: ORC-902: Fix hadoop-common dependency scope in orc-example

2021-08-02 Thread GitBox
guiyanakuang commented on pull request #808: URL: https://github.com/apache/orc/pull/808#issuecomment-891539819 None of the 4 examples can run, because they all need new Configuration(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [orc] guiyanakuang commented on a change in pull request #808: ORC-902: Fix hadoop-common dependency scope in orc-example

2021-08-02 Thread GitBox
guiyanakuang commented on a change in pull request #808: URL: https://github.com/apache/orc/pull/808#discussion_r681444545 ## File path: java/examples/pom.xml ## @@ -50,6 +50,7 @@ org.apache.hadoop hadoop-common + compile Review comment: OK

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #808: ORC-902: Fix hadoop-common dependency scope in orc-example

2021-08-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #808: URL: https://github.com/apache/orc/pull/808#discussion_r68100 ## File path: java/examples/pom.xml ## @@ -50,6 +50,7 @@ org.apache.hadoop hadoop-common + compile Review comment: We

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #708: ORC-806: Upgrade to Apache POM 23

2021-08-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #708: URL: https://github.com/apache/orc/pull/708#discussion_r681444050 ## File path: java/examples/pom.xml ## @@ -50,14 +50,10 @@ org.apache.hadoop hadoop-common - ${hadoop.version} - compile

[GitHub] [orc] dongjoon-hyun commented on pull request #808: ORC-902: fix hadoop-common dependency scope in orc-example

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #808: URL: https://github.com/apache/orc/pull/808#issuecomment-891537040 Thank you for making a PR, @guiyanakuang ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (ORC-902) The example of orc-example cannot be run

2021-08-02 Thread Yiqun Zhang (Jira)
Yiqun Zhang created ORC-902: --- Summary: The example of orc-example cannot be run Key: ORC-902 URL: https://issues.apache.org/jira/browse/ORC-902 Project: ORC Issue Type: Bug Reporter:

[GitHub] [orc] guiyanakuang opened a new pull request #808: fix hadoop-common dependency scope

2021-08-02 Thread GitBox
guiyanakuang opened a new pull request #808: URL: https://github.com/apache/orc/pull/808 ### What changes were proposed in this pull request? run orc-example, Throw an exception ```log Error: A JNI error has occurred, please check your installation and try again

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

2021-08-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #807: URL: https://github.com/apache/orc/pull/807#discussion_r681408207 ## File path: java/mapreduce/src/test/org/apache/orc/mapred/TestOrcFileEvolution.java ## @@ -30,25 +30,20 @@ import org.apache.orc.*; import

[GitHub] [orc] dongjoon-hyun commented on pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #807: URL: https://github.com/apache/orc/pull/807#issuecomment-891492442 cc @williamhyun and @pgaref -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [orc] dongjoon-hyun commented on pull request #801: ORC-893: Remove junit-vintage-engine from shims module

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #801: URL: https://github.com/apache/orc/pull/801#issuecomment-891492354 I made a quick PR for `mapreduce` and `tools` module~ - https://github.com/apache/orc/pull/807 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [orc] dongjoon-hyun opened a new pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

2021-08-02 Thread GitBox
dongjoon-hyun opened a new pull request #807: URL: https://github.com/apache/orc/pull/807 ### What changes were proposed in this pull request? This PR aims to remove old dependencies from `mapreduce` and `tools` modules by removing `junit-vintage-engine`. ### Why are the

[jira] [Created] (ORC-901) Remove junit-vintage-engine from `mapreduce/tools` module

2021-08-02 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-901: - Summary: Remove junit-vintage-engine from `mapreduce/tools` module Key: ORC-901 URL: https://issues.apache.org/jira/browse/ORC-901 Project: ORC Issue Type: Test

[GitHub] [orc] omalley commented on a change in pull request #716: ORC-743: Added conversion of SArg into filters to take advantage of t…

2021-08-02 Thread GitBox
omalley commented on a change in pull request #716: URL: https://github.com/apache/orc/pull/716#discussion_r681300657 ## File path: java/core/src/java/org/apache/orc/filter/impl/IsNullFilter.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [orc] omalley commented on a change in pull request #716: ORC-743: Added conversion of SArg into filters to take advantage of t…

2021-08-02 Thread GitBox
omalley commented on a change in pull request #716: URL: https://github.com/apache/orc/pull/716#discussion_r681236104 ## File path: java/core/src/gen/filters/string_eq.txt ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [orc] dongjoon-hyun commented on pull request #801: ORC-893: Remove junit-vintage-engine from shims module

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #801: URL: https://github.com/apache/orc/pull/801#issuecomment-891214234 I'll backport this test PR to branch-1.7, @williamhyun . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [orc] dongjoon-hyun merged pull request #806: ORC-900: Update doap_orc.rdf for Apache Projects page

2021-08-02 Thread GitBox
dongjoon-hyun merged pull request #806: URL: https://github.com/apache/orc/pull/806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [orc] dongjoon-hyun commented on pull request #806: ORC-900: Update doap_orc.rdf for Apache Projects page

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #806: URL: https://github.com/apache/orc/pull/806#issuecomment-891197083 Thank you so much, @pgaref !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [orc] dongjoon-hyun commented on pull request #806: ORC-900: Update doap_orc.rdf for Apache Projects page

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #806: URL: https://github.com/apache/orc/pull/806#issuecomment-891178871 cc @omalley , @pgaref , @wgtmac , @williamhyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [orc] dongjoon-hyun opened a new pull request #806: ORC-900: Update doap_orc.rdf for Apache Projects page

2021-08-02 Thread GitBox
dongjoon-hyun opened a new pull request #806: URL: https://github.com/apache/orc/pull/806 ### What changes were proposed in this pull request? This PR aims to update `doap_orc.rdf` file. ### Why are the changes needed? The following Apache Projects page is populated

[jira] [Created] (ORC-900) Update doap_orc.rdf for Apache Projects page

2021-08-02 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-900: - Summary: Update doap_orc.rdf for Apache Projects page Key: ORC-900 URL: https://issues.apache.org/jira/browse/ORC-900 Project: ORC Issue Type: Task

[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
pgaref commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-891162685 > BTW, @pgaref . When you click the squash button, GitHub shows you the commit title and body input boxes. > > The content of those input boxes came from the contributor's

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
dongjoon-hyun edited a comment on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-891159575 BTW, @pgaref . When you click the squash button, GitHub shows you the commit title and body input boxes. The content of those input boxes came from the

[GitHub] [orc] dongjoon-hyun commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-891159575 BTW, @pgaref . When you click the squash button, GitHub shows you the commit title and body input boxes. The content of those input boxes came from the contributor's

[GitHub] [orc] dongjoon-hyun merged pull request #805: ORC-899: Archive Apache ORC 1.4.x in `releases` page

2021-08-02 Thread GitBox
dongjoon-hyun merged pull request #805: URL: https://github.com/apache/orc/pull/805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [orc] dongjoon-hyun commented on pull request #805: ORC-899: Archive Apache ORC 1.4.x in `releases` page

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #805: URL: https://github.com/apache/orc/pull/805#issuecomment-891157018 Thank you, @pgaref . BTW, Java16 failure is due to GitHub.com connection timeout. It seems that were a network issue from GitHub.com. Since it's irrelevant, I'll merge

[GitHub] [orc] guiyanakuang commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
guiyanakuang commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890974808 Thank you, @pgaref ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [orc] pgaref merged pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
pgaref merged pull request #803: URL: https://github.com/apache/orc/pull/803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [orc] pgaref commented on pull request #805: ORC-899: Archive Apache ORC 1.4.x in `releases` page

2021-08-02 Thread GitBox
pgaref commented on pull request #805: URL: https://github.com/apache/orc/pull/805#issuecomment-890890518 > Could you review this, @omalley , @pgaref , @wgtmac , @williamhyun ? > I saw [ORC-896](https://issues.apache.org/jira/browse/ORC-896) is filed against Apache ORC 1.4.4, but we are

[GitHub] [orc] dongjoon-hyun commented on pull request #805: ORC-899: Archive Apache ORC 1.4.x in `releases` page

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #805: URL: https://github.com/apache/orc/pull/805#issuecomment-890889074 Could you review this, @omalley , @pgaref , @wgtmac , @williamhyun ? I saw ORC-896 is filed against Apache ORC 1.4.4, but we are not maintaining it. We had better update

[GitHub] [orc] dongjoon-hyun opened a new pull request #805: ORC-899: Archive Apache ORC 1.4.x in `releases` page

2021-08-02 Thread GitBox
dongjoon-hyun opened a new pull request #805: URL: https://github.com/apache/orc/pull/805 ### What changes were proposed in this pull request? This PR aims to mark `Apache ORC 1.4.5` as `archived` instead of `stable`. ### Why are the changes needed? Apache ORC 1.4 was

[jira] [Created] (ORC-899) Archive Apache ORC 1.4.x in `releases` page

2021-08-02 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-899: - Summary: Archive Apache ORC 1.4.x in `releases` page Key: ORC-899 URL: https://issues.apache.org/jira/browse/ORC-899 Project: ORC Issue Type: Task

[GitHub] [orc] guiyanakuang commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
guiyanakuang commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890878909 Thank you so much for review and approval, @dongjoon-hyun ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
pgaref commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890875102 > Before merging, it would be great if we make it sure that these are all instances like this (at least in this file or module), @pgaref . Sure, all seem to be using

[GitHub] [orc] dongjoon-hyun commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890863817 Before merging, it would be great if we make it sure that these are all instances like this (at least in this file or module), @pgaref . -- This is an automated message from

[GitHub] [orc] dongjoon-hyun commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
dongjoon-hyun commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890863121 Yep, @pgaref . I noticed that and wanted to have it in the PR description. :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
pgaref commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890862588 > Thank you for making a PR @guiyanakuang . > > Could you elaborate why this is redundant in the PR description? > > > Remove redundant conditions > > Are these all

[GitHub] [orc] dependabot[bot] opened a new pull request #804: Bump commons-compiler from 3.0.8 to 3.1.6 in /java

2021-08-02 Thread GitBox
dependabot[bot] opened a new pull request #804: URL: https://github.com/apache/orc/pull/804 Bumps [commons-compiler](https://github.com/janino-compiler/janino) from 3.0.8 to 3.1.6. Commits See full diff in https://github.com/janino-compiler/janino/commits/v3.1.6;>compare

[GitHub] [orc] dongjoon-hyun merged pull request #800: ORC-898: Bump threeten-extra from 1.5.0 to 1.7.0

2021-08-02 Thread GitBox
dongjoon-hyun merged pull request #800: URL: https://github.com/apache/orc/pull/800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (ORC-898) Bump threeten-extra from 1.5.0 to 1.7.0

2021-08-02 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created ORC-898: - Summary: Bump threeten-extra from 1.5.0 to 1.7.0 Key: ORC-898 URL: https://issues.apache.org/jira/browse/ORC-898 Project: ORC Issue Type: Improvement

[GitHub] [orc] guiyanakuang opened a new pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
guiyanakuang opened a new pull request #803: URL: https://github.com/apache/orc/pull/803 ### What changes were proposed in this pull request? Remove redundant conditions ### Why are the changes needed? Optimization loop termination condition in

[jira] [Created] (ORC-897) optimization loop termination condition in readerIsCompatible method

2021-08-02 Thread Yiqun Zhang (Jira)
Yiqun Zhang created ORC-897: --- Summary: optimization loop termination condition in readerIsCompatible method Key: ORC-897 URL: https://issues.apache.org/jira/browse/ORC-897 Project: ORC Issue