dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892386046
This is the final piece of JUnit5 migration for 1.7.0 release. I hope `main`
and `branch-1.7` similarly because this is a big change.
--
This is an automated message from the
dongjoon-hyun commented on pull request #810:
URL: https://github.com/apache/orc/pull/810#issuecomment-892385379
Thank you for updating, @guiyanakuang . Now, do we have both structure? It
looks like a regression in memory perspective.
```
public static class UserMetadata {
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892383237
cc @williamhyun and @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guiyanakuang commented on pull request #810:
URL: https://github.com/apache/orc/pull/810#issuecomment-892378836
> @guiyanakuang . Technically, this looks reasonable because Java
`WriterImpl` ensures that there is no duplicated keys at least Java
layer(writer and reader)
>
> ```java
dongjoon-hyun merged pull request #735:
URL: https://github.com/apache/orc/pull/735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun edited a comment on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892366424
It's `findbags` failures on the existing code.
```
[INFO] --- findbugs-maven-plugin:3.0.5:check (analyze-compile) @ orc-core ---
[INFO] BugInstance size is 2
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892366424
It's `findbags` failures.
```
[INFO] --- findbugs-maven-plugin:3.0.5:check (analyze-compile) @ orc-core ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
dongjoon-hyun commented on a change in pull request #813:
URL: https://github.com/apache/orc/pull/813#discussion_r682277668
##
File path: java/pom.xml
##
@@ -779,28 +779,22 @@
5.7.0
test
-
-org.junit.jupiter
-junit-jupiter-engine
dongjoon-hyun opened a new pull request #813:
URL: https://github.com/apache/orc/pull/813
### What changes were proposed in this pull request?
This PR removes
### Why are the changes needed?
After this PR, Apache ORC JUnit5 migration is finished.
### How was
Dongjoon Hyun created ORC-907:
-
Summary: Remove junit-vintage-engine from core module
Key: ORC-907
URL: https://issues.apache.org/jira/browse/ORC-907
Project: ORC
Issue Type: Test
dongjoon-hyun merged pull request #809:
URL: https://github.com/apache/orc/pull/809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-892344710
Thank you so much, @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on pull request #716:
URL: https://github.com/apache/orc/pull/716#issuecomment-892338572
Now, `main` branch has hive-storage-api 2.8.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun merged pull request #773:
URL: https://github.com/apache/orc/pull/773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #773:
URL: https://github.com/apache/orc/pull/773#issuecomment-892336083
All Java test passed with GitHub Action (Java8/11/16/17-ea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjoon-hyun commented on pull request #773:
URL: https://github.com/apache/orc/pull/773#issuecomment-892328492
If CIs pass, I'll merge this to main/branch-1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongjoon-hyun commented on pull request #773:
URL: https://github.com/apache/orc/pull/773#issuecomment-892328262
Thank you, @omalley . I also saw that 2.8.1 is published already.
- https://repo1.maven.org/maven2/org/apache/hive/hive-storage-api/2.8.1/
The pom is updated and I
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-892325596
cc @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun merged pull request #811:
URL: https://github.com/apache/orc/pull/811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #811:
URL: https://github.com/apache/orc/pull/811#issuecomment-892318727
cc @pgaref and @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dongjoon-hyun merged pull request #812:
URL: https://github.com/apache/orc/pull/812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guiyanakuang commented on a change in pull request #810:
URL: https://github.com/apache/orc/pull/810#discussion_r682234526
##
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##
@@ -569,7 +561,13 @@ public ReaderImpl(Path path, OrcFile.ReaderOptions
options)
guiyanakuang commented on a change in pull request #810:
URL: https://github.com/apache/orc/pull/810#discussion_r682230563
##
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##
@@ -569,7 +561,13 @@ public ReaderImpl(Path path, OrcFile.ReaderOptions
options)
guiyanakuang commented on a change in pull request #810:
URL: https://github.com/apache/orc/pull/810#discussion_r682230563
##
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##
@@ -569,7 +561,13 @@ public ReaderImpl(Path path, OrcFile.ReaderOptions
options)
omalley opened a new pull request #812:
URL: https://github.com/apache/orc/pull/812
This is to get HIVE-25400 & HIVE-25190 fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun commented on a change in pull request #668:
URL: https://github.com/apache/orc/pull/668#discussion_r682156100
##
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##
@@ -23,6 +23,7 @@
import java.time.ZoneOffset;
import
dongjoon-hyun opened a new pull request #811:
URL: https://github.com/apache/orc/pull/811
### What changes were proposed in this pull request?
### Why are the changes needed?
### How was this patch tested?
--
This is an automated message from the
dongjoon-hyun commented on a change in pull request #668:
URL: https://github.com/apache/orc/pull/668#discussion_r682155030
##
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##
@@ -23,6 +23,7 @@
import java.time.ZoneOffset;
import
Owen O'Malley created ORC-906:
-
Summary: Upgrade branch-1.6 to storage-api 2.7.3
Key: ORC-906
URL: https://issues.apache.org/jira/browse/ORC-906
Project: ORC
Issue Type: Improvement
omalley commented on a change in pull request #810:
URL: https://github.com/apache/orc/pull/810#discussion_r682128050
##
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##
@@ -569,7 +561,13 @@ public ReaderImpl(Path path, OrcFile.ReaderOptions
options)
pavibhai commented on a change in pull request #716:
URL: https://github.com/apache/orc/pull/716#discussion_r682128823
##
File path: java/core/pom.xml
##
@@ -114,6 +119,10 @@
net.bytebuddy
byte-buddy
+
Review comment:
Removed
--
This is an
dongjoon-hyun commented on a change in pull request #810:
URL: https://github.com/apache/orc/pull/810#discussion_r682099791
##
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##
@@ -569,7 +561,13 @@ public ReaderImpl(Path path, OrcFile.ReaderOptions
options)
dongjoon-hyun commented on pull request #735:
URL: https://github.com/apache/orc/pull/735#issuecomment-891996997
Thank you for pinging me, @belugabehr . I'll review this today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Dongjoon Hyun created ORC-905:
-
Summary: Add an integration test for `example`
Key: ORC-905
URL: https://issues.apache.org/jira/browse/ORC-905
Project: ORC
Issue Type: Test
Components:
dongjoon-hyun edited a comment on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-891993721
Could you review this please, @williamhyun ?
I made this PR first because the whole change is too big for a single review.
--
This is an automated message from
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-891993721
Could you review this please, @williamhyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun commented on pull request #787:
URL: https://github.com/apache/orc/pull/787#issuecomment-891958152
Thank you for closing this, @belugabehr .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
belugabehr closed pull request #787:
URL: https://github.com/apache/orc/pull/787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
belugabehr commented on pull request #735:
URL: https://github.com/apache/orc/pull/735#issuecomment-891850085
@dongjoon-hyun Is there anything else you require to move this PR forward?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
Yiqun Zhang created ORC-904:
---
Summary: Optimize userMetadata data structure to avoid traversal
Key: ORC-904
URL: https://issues.apache.org/jira/browse/ORC-904
Project: ORC
Issue Type: Improvement
guiyanakuang opened a new pull request #810:
URL: https://github.com/apache/orc/pull/810
### What changes were proposed in this pull request?
ReaderImpl.java
```java
@Override
public ByteBuffer getMetadataValue(String key) {
for(OrcProto.UserMetadataItem
dongjoon-hyun commented on a change in pull request #809:
URL: https://github.com/apache/orc/pull/809#discussion_r681550566
##
File path: java/core/src/test/org/apache/orc/TestVectorOrcFile.java
##
@@ -88,32 +89,21 @@
import java.util.Map;
import java.util.Random;
import
dongjoon-hyun opened a new pull request #809:
URL: https://github.com/apache/orc/pull/809
### What changes were proposed in this pull request?
This PR aims to migrate `TestVectorOrcFile` to JUnit5.
### Why are the changes needed?
This is the first step to migrate `core`
Dongjoon Hyun created ORC-903:
-
Summary: Migrate TestVectorOrcFile to JUnit5
Key: ORC-903
URL: https://issues.apache.org/jira/browse/ORC-903
Project: ORC
Issue Type: Test
Components:
dongjoon-hyun commented on pull request #793:
URL: https://github.com/apache/orc/pull/793#issuecomment-891625791
I backported this to branch-1.7, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
45 matches
Mail list logo
