Hi, All.
The following is the Apache ORC 1.7.0 release and adoption status (as of
today).
2021-09-15: Apache ORC 1.7.0 is released
2021-09-20: Apache Spark (dongjoon,
https://github.com/apache/spark/pull/34045)
2021-09-20: Apache Iceberg (william,
https://github.com/apache/iceberg/pull/3160)
dongjoon-hyun commented on pull request #915:
URL: https://github.com/apache/orc/pull/915#issuecomment-928756377
cc @omalley since this is ORC-98.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928754642
Thank you, @noirello and @wgtmac . BTW, if this is for newer VC++, do we
need this at main/branch-1.7/branch-1.6?
--
This is an automated message from the Apache Git Service.
dongjoon-hyun commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928752556
#918 is merged now. Feel free to proceed.
BTW, I'm not sure how to re-trigger `AppVeyor`.
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on pull request #918:
URL: https://github.com/apache/orc/pull/918#issuecomment-928751211
This landed at all live branches, `main/branch-1.7/branch-1.6`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjoon-hyun merged pull request #918:
URL: https://github.com/apache/orc/pull/918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guiyanakuang commented on a change in pull request #917:
URL: https://github.com/apache/orc/pull/917#discussion_r717203373
##
File path: c++/src/Statistics.hh
##
@@ -964,7 +964,23 @@ namespace orc {
_stats.setSum(sum);
}
-void update(int64_t value, int
dongjoon-hyun commented on a change in pull request #917:
URL: https://github.com/apache/orc/pull/917#discussion_r717202883
##
File path: java/core/src/test/org/apache/orc/TestColumnStatistics.java
##
@@ -50,6 +51,16 @@
*/
public class TestColumnStatistics {
+ @Test
+
guiyanakuang commented on a change in pull request #917:
URL: https://github.com/apache/orc/pull/917#discussion_r717197131
##
File path: c++/src/Statistics.hh
##
@@ -964,7 +964,23 @@ namespace orc {
_stats.setSum(sum);
}
-void update(int64_t value, int
guiyanakuang commented on pull request #918:
URL: https://github.com/apache/orc/pull/918#issuecomment-928712712
> I'd suggest to create a JIRA to associate to this upgrade explicitly.
No problem, I've created the issue and bind the pr.
--
This is an automated message from the
Yiqun Zhang created ORC-1010:
Summary: Bump tzdata from tzdata-2020e-1.tar.xz to
tzdata-2021b-1.tar.xz
Key: ORC-1010
URL: https://issues.apache.org/jira/browse/ORC-1010
Project: ORC
Issue Type:
wgtmac commented on a change in pull request #917:
URL: https://github.com/apache/orc/pull/917#discussion_r717192800
##
File path: c++/src/Statistics.hh
##
@@ -964,7 +964,23 @@ namespace orc {
_stats.setSum(sum);
}
-void update(int64_t value, int
wgtmac commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928704113
Thanks for the quick fix @noirello ! I will hold this fix until
https://github.com/apache/orc/pull/918 is merged to make AppVeyor build happy.
--
This is an automated message from
wgtmac commented on pull request #918:
URL: https://github.com/apache/orc/pull/918#issuecomment-928700590
I'd suggest to create a JIRA to associate to this upgrade explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
noirello opened a new pull request #919:
URL: https://github.com/apache/orc/pull/919
### What changes were proposed in this pull request?
Include string in ExpressionTree.hh.
### Why are the changes needed?
Without it the library cannot be built on Windows with
noirello created ORC-1009:
-
Summary: [C++] Missing string include causes build failure with
MSVC++
Key: ORC-1009
URL: https://issues.apache.org/jira/browse/ORC-1009
Project: ORC
Issue Type: Bug
guiyanakuang commented on pull request #917:
URL: https://github.com/apache/orc/pull/917#issuecomment-927926777
> Thanks for the PR @guiyanakuang -- can we please add a test demonstrating
the issue?
You're right, I'll add test cases later. : )
--
This is an automated message from
pgaref commented on pull request #917:
URL: https://github.com/apache/orc/pull/917#issuecomment-927908938
Thanks for the PR @guiyanakuang -- can we please add a test demonstrating
the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
guiyanakuang opened a new pull request #918:
URL: https://github.com/apache/orc/pull/918
### What changes were proposed in this pull request?
```cmd
CUSTOMBUILD : error : downloading
'ftp://cygwin.osuosl.org/pub/cygwin/noarch/release/tzdata/tzdata-2020e-1.tar.xz'
failed
guiyanakuang commented on pull request #917:
URL: https://github.com/apache/orc/pull/917#issuecomment-927722022
```cmd
CUSTOMBUILD : error : downloading
'ftp://cygwin.osuosl.org/pub/cygwin/noarch/release/tzdata/tzdata-2020e-1.tar.xz'
failed [C:\projects\orc\build\tzdata_ep.vcxproj]
guiyanakuang opened a new pull request #917:
URL: https://github.com/apache/orc/pull/917
### What changes were proposed in this pull request?
Fix overflow detection code for C++ int64_t / java long.
> ORC-338 Workaround C++ compiler bug in xcode 9.3 by removing an inline
guiyanakuang commented on pull request #915:
URL: https://github.com/apache/orc/pull/915#issuecomment-927619421
Agreed, I also think that using a string to mark the implementation feels
unreliable. But the good thing is that the current implementation proves the
feasibility. A new module
wgtmac commented on pull request #915:
URL: https://github.com/apache/orc/pull/915#issuecomment-927612662
> Hi @dongjoon-hyun @wgtmac. After some testing and some thought, I have
decided to modify this pr in the following way, and we will discuss any
disagreements.
>
> ## Enhancing
guiyanakuang commented on pull request #915:
URL: https://github.com/apache/orc/pull/915#issuecomment-927611970
@wgtmac You're right, we need to check the value * repetitions first, I've
created the issue, added the c++ and java component tags and I'll try to fix it
later.
--
This is
wgtmac commented on pull request #915:
URL: https://github.com/apache/orc/pull/915#issuecomment-927607518
> In some environments the test has an overflow check that is not as
expected. I haven't figured out why, but I believe this overflow detection code
is incorrect.
>
guiyanakuang commented on pull request #915:
URL: https://github.com/apache/orc/pull/915#issuecomment-927577261
In some environments the test has an overflow check that is not as expected.
I haven't figured out why, but I believe this overflow detection code is
incorrect.
Yiqun Zhang created ORC-1008:
Summary: Overflow detection code is incorrect in
IntegerColumnStatisticsImpl
Key: ORC-1008
URL: https://issues.apache.org/jira/browse/ORC-1008
Project: ORC
Issue
27 matches
Mail list logo
