guiyanakuang commented on pull request #967:
URL: https://github.com/apache/orc/pull/967#issuecomment-985290716
> +1, LGTM. Thank you, @guiyanakuang . For C++ case, could you file a new
JIRA for that? [ORC-1053](https://issues.apache.org/jira/browse/ORC-1053) is
enough for Java-only patch
Yiqun Zhang created ORC-1055:
Summary: [C++] Timestamp values read in Hive are different when
using ORC file created using CSV to ORC converter tools
Key: ORC-1055
URL: https://issues.apache.org/jira/browse/ORC-1055
dongjoon-hyun commented on pull request #967:
URL: https://github.com/apache/orc/pull/967#issuecomment-985280738
Merged to main/1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun merged pull request #967:
URL: https://github.com/apache/orc/pull/967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guiyanakuang commented on pull request #967:
URL: https://github.com/apache/orc/pull/967#issuecomment-984469903
> Also, cc @wgtmac since C++ tool seems to have the same issue according to
the JIRA.
I have also debugged some of the C++ code. It looks like `strptime` can't
convert
guiyanakuang commented on a change in pull request #967:
URL: https://github.com/apache/orc/pull/967#discussion_r760927707
##
File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation
guiyanakuang commented on a change in pull request #967:
URL: https://github.com/apache/orc/pull/967#discussion_r760890059
##
File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation
dongjoon-hyun commented on a change in pull request #967:
URL: https://github.com/apache/orc/pull/967#discussion_r760887860
##
File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation
dongjoon-hyun commented on a change in pull request #967:
URL: https://github.com/apache/orc/pull/967#discussion_r760887314
##
File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation
dongjoon-hyun commented on a change in pull request #967:
URL: https://github.com/apache/orc/pull/967#discussion_r760886324
##
File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation
10 matches
Mail list logo