[GitHub] [orc] guiyanakuang commented on pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the internal defau

2021-12-02 Thread GitBox
guiyanakuang commented on pull request #967: URL: https://github.com/apache/orc/pull/967#issuecomment-985290716 > +1, LGTM. Thank you, @guiyanakuang . For C++ case, could you file a new JIRA for that? [ORC-1053](https://issues.apache.org/jira/browse/ORC-1053) is enough for Java-only patch

[jira] [Created] (ORC-1055) [C++] Timestamp values read in Hive are different when using ORC file created using CSV to ORC converter tools

2021-12-02 Thread Yiqun Zhang (Jira)
Yiqun Zhang created ORC-1055: Summary: [C++] Timestamp values read in Hive are different when using ORC file created using CSV to ORC converter tools Key: ORC-1055 URL: https://issues.apache.org/jira/browse/ORC-1055

[GitHub] [orc] dongjoon-hyun commented on pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the internal defa

2021-12-02 Thread GitBox
dongjoon-hyun commented on pull request #967: URL: https://github.com/apache/orc/pull/967#issuecomment-985280738 Merged to main/1.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [orc] dongjoon-hyun merged pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the internal default pr

2021-12-02 Thread GitBox
dongjoon-hyun merged pull request #967: URL: https://github.com/apache/orc/pull/967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [orc] guiyanakuang commented on pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the internal defau

2021-12-02 Thread GitBox
guiyanakuang commented on pull request #967: URL: https://github.com/apache/orc/pull/967#issuecomment-984469903 > Also, cc @wgtmac since C++ tool seems to have the same issue according to the JIRA. I have also debugged some of the C++ code. It looks like `strptime` can't convert

[GitHub] [orc] guiyanakuang commented on a change in pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the in

2021-12-02 Thread GitBox
guiyanakuang commented on a change in pull request #967: URL: https://github.com/apache/orc/pull/967#discussion_r760927707 ## File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [orc] guiyanakuang commented on a change in pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the in

2021-12-02 Thread GitBox
guiyanakuang commented on a change in pull request #967: URL: https://github.com/apache/orc/pull/967#discussion_r760890059 ## File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the i

2021-12-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #967: URL: https://github.com/apache/orc/pull/967#discussion_r760887860 ## File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the i

2021-12-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #967: URL: https://github.com/apache/orc/pull/967#discussion_r760887314 ## File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the i

2021-12-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #967: URL: https://github.com/apache/orc/pull/967#discussion_r760886324 ## File path: java/tools/src/test/org/apache/orc/tools/convert/TestConvert.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation