[GitHub] [orc] cxzl25 commented on pull request #979: ORC-1065: Fix ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread GitBox
cxzl25 commented on pull request #979: URL: https://github.com/apache/orc/pull/979#issuecomment-1001905299 > Could you add a test case for your code, @cxzl25 ? ok, let me see how to add a ut to cover this case. -- This is an automated message from the Apache Git Service. To respond

[jira] [Created] (ORC-1067) Upgrade ZSTD to 1.5.1

2021-12-27 Thread David Christle (Jira)
David Christle created ORC-1067: --- Summary: Upgrade ZSTD to 1.5.1 Key: ORC-1067 URL: https://issues.apache.org/jira/browse/ORC-1067 Project: ORC Issue Type: Improvement Components: C++

[GitHub] [orc] williamhyun merged pull request #978: ORC-1066: Bump guava from 30.1.1-jre to 31.0.1-jre

2021-12-27 Thread GitBox
williamhyun merged pull request #978: URL: https://github.com/apache/orc/pull/978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[jira] [Created] (ORC-1066) Bump guava from 30.1.1-jre to 31.0.1-jre

2021-12-27 Thread William Hyun (Jira)
William Hyun created ORC-1066: - Summary: Bump guava from 30.1.1-jre to 31.0.1-jre Key: ORC-1066 URL: https://issues.apache.org/jira/browse/ORC-1066 Project: ORC Issue Type: Improvement

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #979: ORC-1065: Fix ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread GitBox
dongjoon-hyun edited a comment on pull request #979: URL: https://github.com/apache/orc/pull/979#issuecomment-1001881070 It seems that the PR doesn't pass the UTs. Could you check the UT failures? ``` Error: Failures: Error:TestReaderImpl.testOrcTailStripeStats:382 expected: <

[GitHub] [orc] dongjoon-hyun commented on pull request #979: ORC-1065: Fix ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread GitBox
dongjoon-hyun commented on pull request #979: URL: https://github.com/apache/orc/pull/979#issuecomment-1001881070 It seems that the PR doesn't pass the UTs. Did you test your patch in your production? ``` Error: Failures: Error:TestReaderImpl.testOrcTailStripeStats:382 expect

[GitHub] [orc] cxzl25 commented on pull request #979: ORC-1065: Fix ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread GitBox
cxzl25 commented on pull request #979: URL: https://github.com/apache/orc/pull/979#issuecomment-1001865778 cc @pgaref @omalley @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [orc] cxzl25 commented on pull request #979: ORC-1065: Fix ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread GitBox
cxzl25 commented on pull request #979: URL: https://github.com/apache/orc/pull/979#issuecomment-1001865038 We used Spark 3.2.0, Hive2.3.9, Orc 1.6.11, Set `spark.sql.hive.convertMetastoreOrc=false` in spark, and querying a table triggers this problem for the second time. The curre

[GitHub] [orc] cxzl25 commented on pull request #979: ORC-1065: Fix ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread GitBox
cxzl25 commented on pull request #979: URL: https://github.com/apache/orc/pull/979#issuecomment-1001863992 ## main branch https://github.com/apache/orc/blob/3a2cb60e4ab6af6305c351fbdb51b98f460f64a0/java/core/src/java/org/apache/orc/impl/ReaderImpl.java#L720-L725 ## branch-1.5

[GitHub] [orc] cxzl25 opened a new pull request #979: ORC-1065: Fix ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread GitBox
cxzl25 opened a new pull request #979: URL: https://github.com/apache/orc/pull/979 ### What changes were proposed in this pull request? Use buffer limit as `readSize` to avoid `IndexOutOfBoundsException`. ### Why are the changes needed? ORC-251 remove `ReaderImpl.extractFileTail

[jira] [Created] (ORC-1065) ReaderImpl.extractFileTail IndexOutOfBoundsException

2021-12-27 Thread dzcxzl (Jira)
dzcxzl created ORC-1065: --- Summary: ReaderImpl.extractFileTail IndexOutOfBoundsException Key: ORC-1065 URL: https://issues.apache.org/jira/browse/ORC-1065 Project: ORC Issue Type: Bug Componen

[GitHub] [orc] coderex2522 commented on pull request #975: ORC-1055: [C++] Add the timezone option for the csv-import tool

2021-12-27 Thread GitBox
coderex2522 commented on pull request #975: URL: https://github.com/apache/orc/pull/975#issuecomment-1001843144 The PR title and descrition has been modified, @dongjoon-hyun please take a look again! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #975: ORC-1055: [C++] Set timezone writer options for csv-import tool

2021-12-27 Thread GitBox
dongjoon-hyun edited a comment on pull request #975: URL: https://github.com/apache/orc/pull/975#issuecomment-1001833835 Thank you for updating, @coderex2522 . Could you revise the PR title and description according to the new code? -- This is an automated message from the Apache Git Ser

[GitHub] [orc] dongjoon-hyun commented on pull request #975: ORC-1055: [C++] Set timezone writer options for csv-import tool

2021-12-27 Thread GitBox
dongjoon-hyun commented on pull request #975: URL: https://github.com/apache/orc/pull/975#issuecomment-1001833835 Thank you for updating, @coderex2522 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [orc] dependabot[bot] opened a new pull request #978: Bump guava from 30.1.1-jre to 31.0.1-jre in /java

2021-12-27 Thread GitBox
dependabot[bot] opened a new pull request #978: URL: https://github.com/apache/orc/pull/978 Bumps [guava](https://github.com/google/guava) from 30.1.1-jre to 31.0.1-jre. Release notes Sourced from https://github.com/google/guava/releases";>guava's releases. 31.0.1 Maven