[GitHub] [orc] noirello commented on pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns

noirello commented on PR #1088: URL: https://github.com/apache/orc/pull/1088#issuecomment-1102159784 > +1, LGTM. Do we need this at ORC 1.7.5? Yes, I think this should be included in the 1.7 branch. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1087: ORC-1150: [C++] Optimize RowReaderImpl::computeBatchSize() by pre-computation

dongjoon-hyun commented on code in PR #1087: URL: https://github.com/apache/orc/pull/1087#discussion_r852637818 ## c++/src/sargs/SargsApplier.hh: ## @@ -60,10 +60,11 @@ namespace orc { const std::map& bloomFilters); /** - * Return a vector of b

[GitHub] [orc] wgtmac commented on a diff in pull request #1087: ORC-1150: [C++] Optimize RowReaderImpl::computeBatchSize() by pre-computation

wgtmac commented on code in PR #1087: URL: https://github.com/apache/orc/pull/1087#discussion_r852596045 ## c++/src/Reader.cc: ## @@ -1186,41 +1186,46 @@ namespace orc { uint64_t currentRowInStripe,

[GitHub] [orc] stiga-huang merged pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns

stiga-huang merged PR #1088: URL: https://github.com/apache/orc/pull/1088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

[GitHub] [orc] stiga-huang commented on a diff in pull request #1087: ORC-1150: [C++] Optimize RowReaderImpl::computeBatchSize() by pre-computation

stiga-huang commented on code in PR #1087: URL: https://github.com/apache/orc/pull/1087#discussion_r852580133 ## c++/src/Reader.cc: ## @@ -1186,41 +1186,46 @@ namespace orc { uint64_t currentRowInStripe,

[GitHub] [orc] coderex2522 commented on a diff in pull request #1089: ORC-1152:[C++] Support writing short decimals in RLEv2

coderex2522 commented on code in PR #1089: URL: https://github.com/apache/orc/pull/1089#discussion_r852556124 ## c++/test/TestWriter.cc: ## @@ -1996,5 +1996,5 @@ namespace orc { } } - INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(), FileVers

[GitHub] [orc] wgtmac commented on a diff in pull request #1087: ORC-1150: [C++] Optimize RowReaderImpl::computeBatchSize() by pre-computation

wgtmac commented on code in PR #1087: URL: https://github.com/apache/orc/pull/1087#discussion_r852538936 ## c++/src/Reader.cc: ## @@ -1186,41 +1186,46 @@ namespace orc { uint64_t currentRowInStripe,

[GitHub] [orc] stiga-huang commented on a diff in pull request #1087: ORC-1150: [C++] Optimize RowReaderImpl::computeBatchSize() by pre-computation

stiga-huang commented on code in PR #1087: URL: https://github.com/apache/orc/pull/1087#discussion_r852537049 ## c++/src/Reader.cc: ## @@ -1186,41 +1186,46 @@ namespace orc { uint64_t currentRowInStripe,

[GitHub] [orc] github-actions[bot] commented on pull request #101: ORC-156

github-actions[bot] commented on PR #101: URL: https://github.com/apache/orc/pull/101#issuecomment-1101868733 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #142: [ORC-218] Cache timezone information in the library.

github-actions[bot] commented on PR #142: URL: https://github.com/apache/orc/pull/142#issuecomment-1101868720 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #189: ORC-210 Add new encodings and benchmarks for new double encoding.

github-actions[bot] commented on PR #189: URL: https://github.com/apache/orc/pull/189#issuecomment-1101868706 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #283: ORC-378

github-actions[bot] commented on PR #283: URL: https://github.com/apache/orc/pull/283#issuecomment-1101868694 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #308: Covert tool should create a lowercase schema

github-actions[bot] commented on PR #308: URL: https://github.com/apache/orc/pull/308#issuecomment-1101868682 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #483: ORC-601: Add more debug info to error messages in the scanner

github-actions[bot] commented on PR #483: URL: https://github.com/apache/orc/pull/483#issuecomment-1101868668 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #496: ORC-624: Fix UBSan errors reported in the testsuite:

github-actions[bot] commented on PR #496: URL: https://github.com/apache/orc/pull/496#issuecomment-1101868662 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #504: ORC-625: Improve dictionary lookup by marking common prefixes.

github-actions[bot] commented on PR #504: URL: https://github.com/apache/orc/pull/504#issuecomment-1101868650 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #524: ZSTD_STATIC_LIB_NAME: Avoid double .a extensions

github-actions[bot] commented on PR #524: URL: https://github.com/apache/orc/pull/524#issuecomment-1101868638 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #564: ORC-274: Remove columnNames field from Reader.Options

github-actions[bot] commented on PR #564: URL: https://github.com/apache/orc/pull/564#issuecomment-1101868623 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #586: ORC-703 : Fix RLE encoding bug on large negative integer.

github-actions[bot] commented on PR #586: URL: https://github.com/apache/orc/pull/586#issuecomment-1101868605 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] github-actions[bot] commented on pull request #601: ORC-703 : Fix RLE encoding bug on large negative integer.

github-actions[bot] commented on PR #601: URL: https://github.com/apache/orc/pull/601#issuecomment-1101868593 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1089: ORC-1152:[C++] Support writing short decimals in RLEv2

dongjoon-hyun commented on code in PR #1089: URL: https://github.com/apache/orc/pull/1089#discussion_r852359519 ## c++/test/TestWriter.cc: ## @@ -1996,5 +1996,5 @@ namespace orc { } } - INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(), FileVe

[jira] [Created] (ORC-1153) Bump byte-buddy from 1.12.8 to 1.12.9

William Hyun created ORC-1153: - Summary: Bump byte-buddy from 1.12.8 to 1.12.9 Key: ORC-1153 URL: https://issues.apache.org/jira/browse/ORC-1153 Project: ORC Issue Type: Improvement Com

[GitHub] [orc] williamhyun merged pull request #1091: ORC-1153: Bump byte-buddy from 1.12.8 to 1.12.9 in /java

williamhyun merged PR #1091: URL: https://github.com/apache/orc/pull/1091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

[GitHub] [orc] dependabot[bot] opened a new pull request, #1091: Bump byte-buddy from 1.12.8 to 1.12.9 in /java

dependabot[bot] opened a new pull request, #1091: URL: https://github.com/apache/orc/pull/1091 Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.8 to 1.12.9. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>byte-buddy's releases. Byt

[GitHub] [orc] dependabot[bot] opened a new pull request, #1090: Bump hive.version from 3.1.2 to 3.1.3 in /java

dependabot[bot] opened a new pull request, #1090: URL: https://github.com/apache/orc/pull/1090 Bumps `hive.version` from 3.1.2 to 3.1.3. Updates `hive-exec` from 3.1.2 to 3.1.3 Updates `hive-serde` from 3.1.2 to 3.1.3 Updates `hive-service-rpc` from 3.1.2 to 3.1.3

[GitHub] [orc] noirello commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns

noirello commented on code in PR #1088: URL: https://github.com/apache/orc/pull/1088#discussion_r852041432 ## c++/test/TestTimestampStatistics.cc: ## @@ -57,4 +62,97 @@ namespace orc { EXPECT_EQ("Data type: Timestamp\nValues: 12\nHas null: no\nMinimum: 1995-01-01 00:00:00.