Re: [VOTE] Release Apache ORC 1.7.8 (RC0)

2023-01-18 Thread William H.
+1 Thank you, Dongjoon, Gang, Yiqun, Junwang, Pavan, and Deshan, for your participation. Bests, William On Wed, Jan 18, 2023 at 9:54 PM deshan xiao wrote: > > +1 for the release. > > As for ORC-1343 (Ignore orc.create.index), we need more careful > implementation to avoid any issue in reader

Re: [VOTE] Release Apache ORC 1.7.8 (RC0)

2023-01-18 Thread deshan xiao
+1 for the release. As for ORC-1343 (Ignore orc.create.index), we need more careful implementation to avoid any issue in reader & writer. This is not an urgent issue in the current release. BTW, I am very willing to re-implement it in the next release. Thanks, Deshan Xiao On Thu, Jan 19, 2023

Re: [VOTE] Release Apache ORC 1.7.8 (RC0)

2023-01-18 Thread Dongjoon Hyun
In the previous email, the following was a typo. 1.8.2 and 1.7.9 are the correct versions which I wanted to mention. ``` - Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. + Implementing is not the scope of urgent 1.8.2 and 1.7.9 releases. ``` On Wed, Jan 18, 2023 at 9:29 PM

Re: [VOTE] Release Apache ORC 1.7.8 (RC0)

2023-01-18 Thread Dongjoon Hyun
Thank you, Pavan. 1. Yes, it's intentional. First, we cannot remove the added public API. That's the main reason why we couldn't revert the commit physically. This discussion happended on the original PR. Second, we keep the added test case by marking 'ignored' because we want to re-enable the

Re: [VOTE] Release Apache ORC 1.7.8 (RC0)

2023-01-18 Thread Pavan Lanka
I wanted to follow up on ORC-1343 (Ignore orc.create.index). * The discussion in the Jira seems to indicate that we want to revert ORC-1283, but the included changes are not a full revert, was that intentional? * I think any files created with the previous version of the writer with index as

Re: [VOTE] Release Apache ORC 1.7.8 (RC0)

2023-01-18 Thread Junwang Zhao
+1 build and tested on macOS Monterey Version 12.6. Thanks for driving this, William. Regards, Junwang Zhao On Tue, Jan 17, 2023 at 5:47 AM William H. wrote: > > Please vote on releasing the following candidate as Apache ORC version 1.7.8. > > [ ] +1 Release this package as Apache ORC 1.7.8 >

Re: [VOTE] Release Apache ORC 1.7.8 (RC0)

2023-01-18 Thread Yiqun Zhang
+1 Thank you for driving this release, William. Best, Yiqun Gang Wu 于2023年1月17日周二 12:40写道: > +1 > > Thanks for driving this, William. > > Best, > Gang > > On Tue, Jan 17, 2023 at 12:17 PM Dongjoon Hyun > wrote: > > > +1 > > > > Thank you so much, William. > > > > Dongjoon. > > > > On Mon,