GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/311
ORC-407 - Lowerbound and upperbound support in JsonFileDump
As part of this change JsonFileDump will now take into account lowerbound
and upperbound values, specifically, if lowerbound or
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/299
@omalley I updated the PR with the suggested changes, updated the
WriterVersion and put back README.
---
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/299
Hello @omalley
Thanks for the review ! I made the suggested changes, the changes are on a
new commit (there are two commits), I am doing this to save the review history,
let me know if you
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/292
@omalley np, I opened a new PR https://github.com/apache/orc/pull/299
---
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/299
ORC-203 - Update StringStatistics to trim long strings to 1024 characters &
record they were trimmed
Reopening the PR.
You can merge this pull request into a Git repository by running:
$
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/292#discussion_r206636579
--- Diff: java/bench/README.md ---
@@ -1,3 +1,20 @@
+
--- End diff --
Thanks @omalley I updated the PR with suggested changes.
---
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/292#discussion_r205867014
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -584,16 +642,40 @@ public void merge(ColumnStatisticsImpl other
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/292
ORC-203 - Update StringStatistics to trim long strings to 1024 characters &
record they were trimmed
This PR adds the functionality described in ORC-203.
You can merge this pull request in
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/255
ORC-305 - Add column statistics for the size on disk
This PR adds column statistics for the size on disk.
I have updated the Unit Tests to reflect this change, I have also manually
gone
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/213
Hello @omalley
The changes look good, thanks !
---
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/213
Hello @omalley
Thanks for the review, the new PR should incorporate the changes you
suggested.
---
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/213
ORC-278 - Create in memory KeyProvider class
This PR addresses ORC-278 by creating an in-memory implementation of
HadoopShims.KeyProvider interface which can be used for testing.
You can merge
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/208
Updated the PR with suggested changes.
---
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/208
Hello @omalley
Thank you for the review !
I have incorporated most of the changes you proposed, except the one about
copying output bytes.
The thing is I will be needing another buffer
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/208#discussion_r162178962
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/SHA256MaskFactory.java ---
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/208
ORC-250 - Create sha256 mask
Masking strategy that masks String, Varchar, Char and Binary types
as SHA 256 hash.
**For String type:**
All string type of any length will be
Github user moresandeep closed the pull request at:
https://github.com/apache/orc/pull/201
---
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/201
No idea why the cpp build is failing, there are no changes to cpp side in
this PR.
---
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/201
Orc 250 - Create sha256 mask
Masking strategy that masks String, Varchar, Char and Binary types
as SHA 256 hash.
For String type:
All string type of any length will be converted
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/184
@xndai @omalley I updated the PR with the suggested changes, let me know
if you have any questions.
---
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155629181
--- Diff: java/core/src/test/org/apache/orc/impl/mask/TestUnmaskRange.java
---
@@ -0,0 +1,165 @@
+package org.apache.orc.impl.mask
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155629073
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -245,8 +271,8 @@ public void maskData(ColumnVector original
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155629140
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -619,7 +646,7 @@ public double maskDouble(double value
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155628665
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -114,6 +120,10 @@
private final boolean maskDate;
private
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/184
@omalley I updated the PR with your suggestions, thanks for the review !
---
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/184
Updated the PR he changes are as follows:
1. Fixed the find bugs issue.
2. Merged the feature into a single commit.
---
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/187
ORC-260 - Fix a bug in masking data for Decimal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moresandeep/orc ORC-260
Alternatively you can
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/184
Orc 256 unmask range option
This PR contains changes that enables unmasking range option for redact
mask (ORC-256).
1. The react mask would accept an additional option (option #3 in this
28 matches
Mail list logo
