[GitHub] orc pull request #283: ORC-378

2018-06-14 Thread sershe
GitHub user sershe opened a pull request: https://github.com/apache/orc/pull/283 ORC-378 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sershe/orc master-378 Alternatively you can review and apply these changes as the patch at

[GitHub] orc pull request #222: ORC-310 better error handling for codec

2018-03-12 Thread sershe
Github user sershe commented on a diff in the pull request: https://github.com/apache/orc/pull/222#discussion_r173943752 --- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java --- @@ -306,15 +330,24 @@ public void releaseBuffer(ByteBuffer buffer

[GitHub] orc pull request #222: ORC-310 better error handling for codec

2018-03-01 Thread sershe
Github user sershe commented on a diff in the pull request: https://github.com/apache/orc/pull/222#discussion_r171728763 --- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java --- @@ -472,8 +473,9 @@ public static OrcTail extractFileTail(ByteBuffer buffer, long

[GitHub] orc pull request #222: ORC-310 better error handling for codec

2018-03-01 Thread sershe
Github user sershe commented on a diff in the pull request: https://github.com/apache/orc/pull/222#discussion_r171728816 --- Diff: java/core/src/java/org/apache/orc/impl/WriterImpl.java --- @@ -645,6 +645,8 @@ public void appendUserMetadata(List userMetadata) { return

[GitHub] orc issue #222: ORC-310 better error handling for codec

2018-03-01 Thread sershe
Github user sershe commented on the issue: https://github.com/apache/orc/pull/222 Updated the JIRA with motivation. I will rename the flag; there isn't a better way primarily because of the TODOs you are asking me to remove - we don't have access to information about

[GitHub] orc pull request #222: ORC-310 better error handling for codec

2018-02-28 Thread sershe
GitHub user sershe opened a pull request: https://github.com/apache/orc/pull/222 ORC-310 better error handling for codec You can merge this pull request into a Git repository by running: $ git pull https://github.com/sershe/orc orc-310 Alternatively you can review and apply

[GitHub] orc pull request #102: ORC-166 : add codec pool to ORC; make sure end is cal...

2017-03-20 Thread sershe
GitHub user sershe opened a pull request: https://github.com/apache/orc/pull/102 ORC-166 : add codec pool to ORC; make sure end is called on underlyin… …g codecs (Sergey Shelukhin) You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] orc pull request: ORC-55. Resynchronize storage-api and orc with t...

2016-05-24 Thread sershe
Github user sershe commented on the pull request: https://github.com/apache/orc/pull/25#issuecomment-221338899 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and