[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-09 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1094137978 Thank you for verifying and closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-07 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1092246964 One more thing. @williamhyun . If you don't mind, please follow the style of https://github.com/apache/orc/issues/1081 and update your release issue, https://github.com/apache/orc/

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-07 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1092227902 BTW, - if you feel ok, please close this issue and move forward, @williamhyun . :) - Since the same patches are in the branch-1.6, I'll trigger integration test for them separ

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-07 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1092221312 Thank you for rerunning it. Yes, I saw Spark passed and Iceberg has only the following. If we comment out the test, it will pass cleanly. ``` org.apache.iceberg.data.TestMetri

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-05 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1089823997 @williamhyun ORC-1147 landed to main/branch-1.7/1.6. Could you rerun the integration tests, please? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-04 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1088282881 If you get the results, please share them to the dev mailing list, @williamhyun . -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-04 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1088274728 I also quickly re-checked the Iceberg test. So, `TestMetricsRowGroupFilter` passed except the following one mentioned by @guiyanakuang . ``` shouldRead = shouldRead(isNaN(

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-04 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1087744468 Oh, thank you, @guiyanakuang ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [orc] dongjoon-hyun commented on issue #1075: ORC 1.7.4-SNAPSHOT fails with Iceberg Nan count tests

2022-04-03 Thread GitBox
dongjoon-hyun commented on issue #1075: URL: https://github.com/apache/orc/issues/1075#issuecomment-1086942077 Thank you for reporting, @williamhyun . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go