[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value

2022-04-04 Thread GitBox
dongjoon-hyun commented on PR #1077: URL: https://github.com/apache/orc/pull/1077#issuecomment-1088207106 Thank you, @guiyanakuang . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value

2022-04-04 Thread GitBox
dongjoon-hyun commented on PR #1077: URL: https://github.com/apache/orc/pull/1077#issuecomment-1087846051 BTW, @guiyanakuang . Could you check branch-1.6 too when you have a time? We backported the following in branch-1.6. I guess we might have the same issue there. -

[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value

2022-04-04 Thread GitBox
dongjoon-hyun commented on PR #1077: URL: https://github.com/apache/orc/pull/1077#issuecomment-1087834344 I deleted my previous comment about the branch-1.7 test result. At a clean build, I verified this patch in branch-1.7 and backported. Thank you again, @guiyanakuang .

[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value

2022-04-04 Thread GitBox
dongjoon-hyun commented on PR #1077: URL: https://github.com/apache/orc/pull/1077#issuecomment-1087819831 Hi, @guiyanakuang . - Could you make a backporting patch to branch-1.7, please? - This works in `main` branch but not in `branch-1.7`. We need to pass CI. -- This is an