[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
pgaref commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-891162685 > BTW, @pgaref . When you click the squash button, GitHub shows you the commit title and body input boxes. > > The content of those input boxes came from the contributor's

[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
pgaref commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890875102 > Before merging, it would be great if we make it sure that these are all instances like this (at least in this file or module), @pgaref . Sure, all seem to be using

[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition

2021-08-02 Thread GitBox
pgaref commented on pull request #803: URL: https://github.com/apache/orc/pull/803#issuecomment-890862588 > Thank you for making a PR @guiyanakuang . > > Could you elaborate why this is redundant in the PR description? > > > Remove redundant conditions > > Are these all