[GitHub] orc issue #213: ORC-278 - Create in memory KeyProvider class

2018-02-28 Thread moresandeep
Github user moresandeep commented on the issue: https://github.com/apache/orc/pull/213 Hello @omalley The changes look good, thanks ! ---

[GitHub] orc issue #213: ORC-278 - Create in memory KeyProvider class

2018-02-27 Thread omalley
Github user omalley commented on the issue: https://github.com/apache/orc/pull/213 Sandeep, I started making some changes and ended up making pretty substantial changes. Can you look at my changes? https://github.com/omalley/orc/tree/orc-278 ---

[GitHub] orc issue #213: ORC-278 - Create in memory KeyProvider class

2018-02-21 Thread moresandeep
Github user moresandeep commented on the issue: https://github.com/apache/orc/pull/213 Hello @omalley Thanks for the review, the new PR should incorporate the changes you suggested. ---