Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/299
---
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208394170
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -683,6 +787,150 @@ public int hashCode() {
result = 31 * result +
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208402722
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -683,6 +787,150 @@ public int hashCode() {
result = 31 * result +
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208398251
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -584,16 +630,40 @@ public void merge(ColumnStatisticsImpl other) {
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208392941
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -543,35 +551,73 @@ public void reset() {
super.reset();
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208397080
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -584,16 +630,40 @@ public void merge(ColumnStatisticsImpl other) {
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208392060
--- Diff: java/bench/README.md ---
@@ -1,3 +1,20 @@
+
--- End diff --
I don't need this, even when I compile with ANALYZE_JAVA.
---
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208401986
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -683,6 +787,150 @@ public int hashCode() {
result = 31 * result +
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208393137
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -543,35 +551,73 @@ public void reset() {
super.reset();
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208392855
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -543,35 +551,73 @@ public void reset() {
super.reset();
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208398373
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -683,6 +787,150 @@ public int hashCode() {
result = 31 * result +
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208395531
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -584,16 +630,40 @@ public void merge(ColumnStatisticsImpl other) {
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208393268
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -543,35 +551,73 @@ public void reset() {
super.reset();
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208392450
--- Diff: java/core/src/java/org/apache/orc/StringColumnStatistics.java ---
@@ -33,6 +33,20 @@
*/
String getMaximum();
+ /**
+ *
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208392508
--- Diff: java/core/src/java/org/apache/orc/StringColumnStatistics.java ---
@@ -33,6 +33,20 @@
*/
String getMaximum();
+ /**
+ *
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208398032
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -584,16 +630,40 @@ public void merge(ColumnStatisticsImpl other) {
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/299#discussion_r208393342
--- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
---
@@ -543,35 +551,73 @@ public void reset() {
super.reset();
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/299
ORC-203 - Update StringStatistics to trim long strings to 1024 characters &
record they were trimmed
Reopening the PR.
You can merge this pull request into a Git repository by running:
$ git
18 matches
Mail list logo
