Re: [dev] hello again every one Im back and have code to contribute

2014-01-08 Thread Paul Robert Marino
Martin Well writing a full unit test for this module is a little more involved than I wanted to get into right now. Right now I am just looking at the obvious and easy things I can improve, but I will would be willing to do that in the next couple of months. I have tested what I have written so

Re: [dev] hello again every one Im back and have code to contribute

2014-01-07 Thread Martin Gruner
Hi Paul, great, looking very much forward to your pull requests. It is always good if the code does not change the behaviour (output), but makes it more efficient etc., then it is most easy to integrate for us. In case of the TemplateGenerator I would ask you to first write some unit tests cover

Re: [dev] hello again every one Im back and have code to contribute

2014-01-06 Thread Paul Robert Marino
CarlosThank you I'm already familiar with the guidelines since I was very active in the community back in 2006-8 when I maintained and developed an instance of OTRS for a stock exchange. That said I'll look it over to see if any thing other than the ability to submit via Github pull request has cha

Re: [dev] hello again every one Im back and have code to contribute

2014-01-06 Thread Carlos Rodríguez
Hi Paul, You as any other contributor is very welcome to send improvements in the code, thank you! As a suggestion please take a look at the OTRS Development Manual, specially in the code style guide http://doc.otrs.org/developer/3.3/en/html/code-style-guide.html Following this guide lines wi

[dev] hello again every one Im back and have code to contribute

2014-01-06 Thread Paul Robert Marino
hello every one Its been quite a few years since I was on this list. Im working now at an other company where we are implementing OTRS. I have been looking over the code and there has been a lot of progress since I last looked at it. That said there are a few things that struck me as inefficient an