[GitHub] tobsch commented on issue #1535: ModifyCachingHeaders should only apply to html responses

tobsch commented on issue #1535: ModifyCachingHeaders should only apply to html responses URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1535#issuecomment-382755965 @oschaaf Took a look at the code and found out that setting DownstreamCachePurgeLocationPrefix helps to p

[GitHub] morlovich commented on a change in pull request #1766: AddResourceHeader: always set. Ignore pre-existing values

morlovich commented on a change in pull request #1766: AddResourceHeader: always set. Ignore pre-existing values URL: https://github.com/apache/incubator-pagespeed-mod/pull/1766#discussion_r182753430 ## File path: net/instaweb/rewriter/resource_fetch.cc ## @@ -175,6 +175,

[GitHub] oschaaf commented on issue #1766: AddResourceHeader: always set. Ignore pre-existing values

oschaaf commented on issue #1766: AddResourceHeader: always set. Ignore pre-existing values URL: https://github.com/apache/incubator-pagespeed-mod/pull/1766#issuecomment-382745370 @jmarantz absolutely. I'll amend. @morlovich looks nicer indeed, consider it done. -

[GitHub] jmarantz commented on issue #1766: AddResourceHeader: always set. Ignore pre-existing values

jmarantz commented on issue #1766: AddResourceHeader: always set. Ignore pre-existing values URL: https://github.com/apache/incubator-pagespeed-mod/pull/1766#issuecomment-382743891 Well, the directive does specifically indicate "Add", not "Set" or "Replace". Can you just add a new direct

[GitHub] oschaaf commented on issue #1766: AddResourceHeader: always set. Ignore pre-existing values

oschaaf commented on issue #1766: AddResourceHeader: always set. Ignore pre-existing values URL: https://github.com/apache/incubator-pagespeed-mod/pull/1766#issuecomment-382741421 @jmarantz @morlovich any objections to me merging this? -