[GitHub] free6k commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-13 Thread GitBox
free6k commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388714272 I have similar problem ``` nginx version: nginx/1.14.0 built by gcc 4.9.2 (Debian 4.9.2-10)

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-13 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388665742 @oschaaf This seems to be enough to reproduce the issue 90% of the time: https://gist.github.

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-13 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388665742 @oschaaf This seems to be enough to reproduce the issue 90% of the time: https://gist.github.

[GitHub] Thedemon007 commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
Thedemon007 commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388658952 The server has been previously configured varnish with nginix via proxy_pass, I have tried in various ways to disable varni

[GitHub] Thedemon007 commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
Thedemon007 commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388658952 The server has been previously configured varnish with nginix via proxy_pass, I have tried in various ways to disable varni

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-13 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388653519 @jstangroome are you able to set up a minimal reproduction scenario? I'd love to dig into this one, but

[GitHub] oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559#issuecomment-388625787 (Also -- CI is passing, I restarted it. The previous try timed out indeed).

[GitHub] oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559#issuecomment-388625763 Thanks! I suspect that this is effectively a no-op, but regardless I feel it is a solid improvement as it makes ngx_

[GitHub] oschaaf closed pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings

2018-05-13 Thread GitBox
oschaaf closed pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1558 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] oschaaf commented on issue #1558: Fix setting 'gzip_proxied' when applying gzip settings

2018-05-13 Thread GitBox
oschaaf commented on issue #1558: Fix setting 'gzip_proxied' when applying gzip settings URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1558#issuecomment-388625511 LGTM, nice catch! /cc @keesspoelstra This

[GitHub] jmarantz commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
jmarantz commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388624209 What you are seeing when you disable memcached is effectively a pagespeed server-side cache-flush. It won't make any differen

[GitHub] jmarantz commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
jmarantz commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388624209 What you are seeing when you disable memcached is effectively a pagespeed server-side cache-flush. It won't make any differen

[GitHub] dsanders11 commented on issue #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
dsanders11 commented on issue #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559#issuecomment-388623231 The CI failure seems to be a transient failure relating to the job taking too long. Might have had to do with two

[GitHub] Thedemon007 commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
Thedemon007 commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388621097 I tried stop varnish temporarily but not have changes, i can confirm the problem no is varnish the problem is related with

[GitHub] dsanders11 opened a new pull request #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
dsanders11 opened a new pull request #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559 This change may or may not be needed. I spent a frustratingly long time trying to get gzip working with `ngx_pagespeed` in product

[GitHub] dsanders11 opened a new pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings

2018-05-13 Thread GitBox
dsanders11 opened a new pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1558 This fix should be fairly self-explanatory when viewing the code, but the code was setting the wrong command (and may have bee