[GitHub] oschaaf closed pull request #1559: Properly iterate modules looking for gzip commands

2018-05-14 Thread GitBox
oschaaf closed pull request #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388761430 True, I had forgotten about that. I guess a non-gzip request for the HTML may have lead to

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388759087 Well actually .. in the script that demonstrates the issue there is: ``` good_css_url=$(curl

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388756405 >the first request happens without Accept-Encoding: gzip @oschaaf all my testing, in

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388730282 @jstangroome awesome, I have it reproduced now! So one prerequisite that I think exists for the