[GitHub] jmarantz commented on a change in pull request #1802: Prefer Paint Timing API over chrome.loadTimes()

jmarantz commented on a change in pull request #1802: Prefer Paint Timing API over chrome.loadTimes() URL: https://github.com/apache/incubator-pagespeed-mod/pull/1802#discussion_r225510970 ## File path: net/instaweb/rewriter/add_instrumentation.js ## @@ -88,21 +88,30 @@

[GitHub] jmarantz commented on a change in pull request #1802: Prefer Paint Timing API over chrome.loadTimes()

jmarantz commented on a change in pull request #1802: Prefer Paint Timing API over chrome.loadTimes() URL: https://github.com/apache/incubator-pagespeed-mod/pull/1802#discussion_r225511479 ## File path: net/instaweb/rewriter/add_instrumentation.js ## @@ -88,21 +88,30 @@

[GitHub] jmarantz commented on a change in pull request #1802: Prefer Paint Timing API over chrome.loadTimes()

jmarantz commented on a change in pull request #1802: Prefer Paint Timing API over chrome.loadTimes() URL: https://github.com/apache/incubator-pagespeed-mod/pull/1802#discussion_r225510986 ## File path: net/instaweb/rewriter/add_instrumentation.js ## @@ -88,21 +88,30 @@

[GitHub] oschaaf closed pull request #69: rename .src.rpm file to current file name.

oschaaf closed pull request #69: rename .src.rpm file to current file name. URL: https://github.com/apache/incubator-pagespeed-cpanel/pull/69 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] oschaaf commented on issue #69: rename .src.rpm file to current file name.

oschaaf commented on issue #69: rename .src.rpm file to current file name. URL: https://github.com/apache/incubator-pagespeed-cpanel/pull/69#issuecomment-430150254 @mattcheah thanks. I merged https://github.com/apache/incubator-pagespeed-cpanel/pull/48, let's close this one then.

[GitHub] oschaaf closed pull request #48: incompatible with mod_ruid2

oschaaf closed pull request #48: incompatible with mod_ruid2 URL: https://github.com/apache/incubator-pagespeed-cpanel/pull/48 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] oschaaf commented on issue #1802: Prefer Paint Timing API over chrome.loadTimes()

oschaaf commented on issue #1802: Prefer Paint Timing API over chrome.loadTimes() URL: https://github.com/apache/incubator-pagespeed-mod/pull/1802#issuecomment-430149547 This looks good to me; did you get a chance to test this? Is this ready for merging?